jenkins-bot has submitted this change and it was merged.
Change subject: Fixed Style/RedundantSelf RuboCop offense
......................................................................
Fixed Style/RedundantSelf RuboCop offense
Bug: T94401
Change-Id: I31552604b183b631d2f2c73649e2f729e0d4d538
---
M .rubocop_todo.yml
M tests/browser/features/support/pages/special_central_auth.rb
2 files changed, 1 insertion(+), 6 deletions(-)
Approvals:
Hashar: Looks good to me, approved
jenkins-bot: Verified
diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml
index 60df79a..af8baf2 100644
--- a/.rubocop_todo.yml
+++ b/.rubocop_todo.yml
@@ -7,11 +7,6 @@
# Offense count: 1
# Cop supports --auto-correct.
-Style/RedundantSelf:
- Enabled: false
-
-# Offense count: 1
-# Cop supports --auto-correct.
Style/SpaceAfterColon:
Enabled: false
diff --git a/tests/browser/features/support/pages/special_central_auth.rb
b/tests/browser/features/support/pages/special_central_auth.rb
index 91e9562..780e2b2 100644
--- a/tests/browser/features/support/pages/special_central_auth.rb
+++ b/tests/browser/features/support/pages/special_central_auth.rb
@@ -9,7 +9,7 @@
fieldset(:centralauth_info, id:'mw-centralauth-info')
def lookup_user( username )
- self.target_field_element.when_present.send_keys(username)
+ target_field_element.when_present.send_keys(username)
submit_element.when_present.click
end
end
--
To view, visit https://gerrit.wikimedia.org/r/200560
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I31552604b183b631d2f2c73649e2f729e0d4d538
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/CentralAuth
Gerrit-Branch: master
Gerrit-Owner: Zfilipin <[email protected]>
Gerrit-Reviewer: Amire80 <[email protected]>
Gerrit-Reviewer: Cmcmahon <[email protected]>
Gerrit-Reviewer: Dduvall <[email protected]>
Gerrit-Reviewer: Hashar <[email protected]>
Gerrit-Reviewer: Legoktm <[email protected]>
Gerrit-Reviewer: Zfilipin <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
