Krinkle has uploaded a new change for review. https://gerrit.wikimedia.org/r/201691
Change subject: buid: Include utils.js in jsduck and add 'doc' entry point ...................................................................... buid: Include utils.js in jsduck and add 'doc' entry point Include "utils.js" in jsduck (OO.isPlainObject was not being indexed previously because of this). Add npm "doc" script for standard publishing via Jenkins. Move coverage output directory out of "dist/" to a standard "coverage" directory. Nothing was stopping it from being published, other than the fact that our prepublish build script doesn't run unit tests (and as such doesn't produce a coverage report). Also remove redundant node_modules and npm-debug from npmignore as those are always ignored by npm (almost like adding '.git' to '.gitignore'). https://docs.npmjs.com/misc/developers#keeping-files-out-of-your-package Change-Id: I5dbd155ac94d0e6da20dda06b9762207dae580b7 --- M .gitignore M .jshintignore M .npmignore M Gruntfile.js M jsduck.json M package.json M src/util.js 7 files changed, 11 insertions(+), 6 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/oojs/core refs/changes/91/201691/1 diff --git a/.gitignore b/.gitignore index a06d721..3a0f3b3 100644 --- a/.gitignore +++ b/.gitignore @@ -1,3 +1,4 @@ +/coverage /dist/* /docs node_modules diff --git a/.jshintignore b/.jshintignore index 3613f5e..9aa34ea 100644 --- a/.jshintignore +++ b/.jshintignore @@ -1,3 +1,4 @@ -doc/ -lib/ +/coverage +/docs +/lib node_modules diff --git a/.npmignore b/.npmignore index 323481d..31b2a9d 100644 --- a/.npmignore +++ b/.npmignore @@ -1,2 +1,2 @@ -dist/.* -docs +/coverage +/docs diff --git a/Gruntfile.js b/Gruntfile.js index 155451f..cb48928 100644 --- a/Gruntfile.js +++ b/Gruntfile.js @@ -113,8 +113,8 @@ }, reporters: [ 'dots', 'coverage' ], coverageReporter: { reporters: [ - { type: 'html', dir: 'dist/coverage/' }, - { type: 'text-summary', dir: 'dist/coverage/' } + { type: 'html', dir: 'coverage/' }, + { type: 'text-summary', dir: 'coverage/' } ] } }, jquery: { diff --git a/jsduck.json b/jsduck.json index e9f1cfe..1649e69 100644 --- a/jsduck.json +++ b/jsduck.json @@ -7,6 +7,7 @@ "--builtin-classes": true, "--": [ "src/core.js", + "src/util.js", "src/EventEmitter.js", "src/Registry.js", "src/Factory.js" diff --git a/package.json b/package.json index 8db9ae2..af11d3c 100644 --- a/package.json +++ b/package.json @@ -23,6 +23,7 @@ "main": "./dist/oojs.js", "scripts": { "test": "grunt test && node tests/node-index.js", + "doc": "jsduck", "prepublish": "grunt build" }, "dependencies": {}, diff --git a/src/util.js b/src/util.js index 867a6d3..2783a8e 100644 --- a/src/util.js +++ b/src/util.js @@ -3,6 +3,7 @@ /** * Assert whether a value is a plain object or not. * + * @member OO * @param {Mixed} obj * @return {boolean} */ -- To view, visit https://gerrit.wikimedia.org/r/201691 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I5dbd155ac94d0e6da20dda06b9762207dae580b7 Gerrit-PatchSet: 1 Gerrit-Project: oojs/core Gerrit-Branch: master Gerrit-Owner: Krinkle <[email protected]> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
