Aude has uploaded a new change for review.
https://gerrit.wikimedia.org/r/201700
Change subject: Add check in snakview._selectProperty if _variation is already
set
......................................................................
Add check in snakview._selectProperty if _variation is already set
sometimes _selectProperty might be triggered more than once,
depending on keyboard or select events and how quickly one is typing.
if this happens, the value field might get stuck with a spinner.
this change avoids that happening and the selection works better.
Change-Id: If192c130a53cb2a9e7a9add103e356c60d2459c2
---
M view/resources/jquery/wikibase/snakview/snakview.js
1 file changed, 5 insertions(+), 0 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase
refs/changes/00/201700/1
diff --git a/view/resources/jquery/wikibase/snakview/snakview.js
b/view/resources/jquery/wikibase/snakview/snakview.js
index c870021..34fdceb 100644
--- a/view/resources/jquery/wikibase/snakview/snakview.js
+++ b/view/resources/jquery/wikibase/snakview/snakview.js
@@ -270,6 +270,11 @@
_selectProperty: function() {
var self = this;
+ if ( this._variation !== null ) {
+ // already selected
+ return;
+ }
+
// Display spinner as long as the ValueView is loading:
this.$snakValue.empty().append(
$( '<div/>' ).append( $( '<span/>' ).addClass(
'mw-small-spinner' ) )
--
To view, visit https://gerrit.wikimedia.org/r/201700
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: If192c130a53cb2a9e7a9add103e356c60d2459c2
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Aude <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
