Amire80 has uploaded a new change for review.
https://gerrit.wikimedia.org/r/201705
Change subject: Cleanup in ext.cx.campaigns.contributionsmenu.js
......................................................................
Cleanup in ext.cx.campaigns.contributionsmenu.js
Whitespace, vraiable names, comments.
Change-Id: Ib0913e9b7a2b7263bc67a0d28ad19c156a9b68f3
---
M modules/campaigns/ext.cx.campaigns.contributionsmenu.js
1 file changed, 17 insertions(+), 7 deletions(-)
git pull
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/ContentTranslation
refs/changes/05/201705/1
diff --git a/modules/campaigns/ext.cx.campaigns.contributionsmenu.js
b/modules/campaigns/ext.cx.campaigns.contributionsmenu.js
index 4a0d189..fe60c07 100644
--- a/modules/campaigns/ext.cx.campaigns.contributionsmenu.js
+++ b/modules/campaigns/ext.cx.campaigns.contributionsmenu.js
@@ -8,14 +8,16 @@
( function ( $, mw ) {
'use strict';
- var campaign = 'contributionsmenu';
+ var campaignName = 'contributionsmenu';
function showInvitation() {
- var callout, $menu, $trigger, cxLink, $myContributions,
$myTranslations, $myUploads;
+ var $trigger, cxLink, $menu, callout,
+ $myContributions, $myTranslations, $myUploads;
$trigger = $( '#pt-mycontris a' );
+
cxLink = mw.util.getUrl( 'Special:ContentTranslation', {
- campaign: campaign,
+ campaign: campaignName,
to: mw.config.get( 'wgContentLanguage' )
} );
@@ -26,6 +28,7 @@
.text( mw.msg(
'cx-campaign-contributionsmenu-mycontributions' ) )
.attr( 'href', $trigger.attr( 'href' ) )
);
+
$myTranslations = $( '<li>' )
.addClass( 'cx-campaign-translations' )
.append(
@@ -36,6 +39,7 @@
if ( $( '.mw-special-Preferences' ).length ) {
$myTranslations.addClass(
'cx-campaign-new-beta-feature' );
}
+
$myUploads = $( '<li>' )
.addClass( 'cx-campaign-uploads' )
.append(
@@ -43,8 +47,10 @@
.text( mw.msg(
'cx-campaign-contributionsmenu-myuploads' ) )
.attr( 'href',
'//commons.wikimedia.org/wiki/Special:MyUploads' )
);
+
$menu = $( '<ul>' )
.append( $myContributions, $myTranslations, $myUploads
);
+
$trigger.callout( {
trigger: 'manual',
classes: 'cx-campaign-contributionsmenu',
@@ -59,20 +65,24 @@
callout.$dialog.on( 'mouseleave', function () {
callout.hide();
} );
- // Not measuring the shown menu events since there will
be a lot-since the
- // trigger is 'hover'. But can be easily track if
somebody use it to
- // reach CX
+
+ // Not measuring the shown menu events because the
trigger is 'hover'
+ // and there will be a lot of them.
+ // But can be easily track if somebody use it to reach
CX.
}
+
$trigger.on( 'mouseover', show );
+
mw.hook( 'mw.cx.betafeature.enabled' ).add( function () {
// Show after a few milliseconds to get all position
calculation correct
setTimeout( show, 500 );
- mw.hook( 'mw.cx.cta.shown' ).fire( campaign );
+ mw.hook( 'mw.cx.cta.shown' ).fire( campaignName );
} );
}
$( function () {
var blacklist = mw.config.get(
'wgContentTranslationBrowserBlacklist' );
+
if ( !$.client.test( blacklist, null, true ) ) {
showInvitation();
}
--
To view, visit https://gerrit.wikimedia.org/r/201705
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib0913e9b7a2b7263bc67a0d28ad19c156a9b68f3
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/ContentTranslation
Gerrit-Branch: master
Gerrit-Owner: Amire80 <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
