Catrope has submitted this change and it was merged. Change subject: Fixing Pre-Annotations ......................................................................
Fixing Pre-Annotations AnnotationAction and SurfaceFragment now use insertAnnotations. ve.dm.Surface.test * Removed test for annotate method (not needed anymore) ve.dm.SurfaceFragment * Now using getInsertionAnnotations method * Added support for modifying insertion annotations when annotating a zero-length selection ve.dm.Surface * Moved in insertion annotations state from document model * Added insertion annotation interface (enable, disable, areEnabled, get, set, add, and remove) * Simplified handling of annotations on change * Removed annotate method (not used anymore) ve.dm.Document * Removed insertion annotations (moved it to surface model) ve.ce.Surface * Cleaned up handleInsertion and changed it to use the insertion annotations interface on the surface model ve.AnnotationAction * Moved insertion annotation handling out of here since it's now included in the surface fragment Change-Id: I047d656acf7fa1c63f726ca2b0801e1476f84f96 --- M modules/ve/ce/ve.ce.Surface.js M modules/ve/dm/ve.dm.Document.js M modules/ve/dm/ve.dm.Surface.js M modules/ve/dm/ve.dm.SurfaceFragment.js M modules/ve/test/dm/ve.dm.Surface.test.js 5 files changed, 133 insertions(+), 134 deletions(-) Approvals: Catrope: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/33834 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I047d656acf7fa1c63f726ca2b0801e1476f84f96 Gerrit-PatchSet: 3 Gerrit-Project: mediawiki/extensions/VisualEditor Gerrit-Branch: master Gerrit-Owner: Christian <[email protected]> Gerrit-Reviewer: Catrope <[email protected]> Gerrit-Reviewer: Christian <[email protected]> Gerrit-Reviewer: Trevor Parscal <[email protected]> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
