Esanders has uploaded a new change for review.
https://gerrit.wikimedia.org/r/202015
Change subject: Ignore href DOM attribute when comparing links
......................................................................
Ignore href DOM attribute when comparing links
The DOM attribute only exists on elements which came from
HTML, not newly created elements, and the href is already
compared via the model attribute.
Bug: T95160
Change-Id: I544161a70b15797ae0aab957b8bd61ccfc4e8d54
---
M src/dm/annotations/ve.dm.LinkAnnotation.js
1 file changed, 9 insertions(+), 0 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/VisualEditor/VisualEditor
refs/changes/15/202015/1
diff --git a/src/dm/annotations/ve.dm.LinkAnnotation.js
b/src/dm/annotations/ve.dm.LinkAnnotation.js
index 03db7bd..d35df71 100644
--- a/src/dm/annotations/ve.dm.LinkAnnotation.js
+++ b/src/dm/annotations/ve.dm.LinkAnnotation.js
@@ -82,6 +82,15 @@
};
};
+/**
+ * @inherit
+ */
+ve.dm.LinkAnnotation.prototype.getComparableHtmlAttributes = function () {
+ var comparableAttributes =
ve.dm.LinkAnnotation.super.prototype.getComparableHtmlAttributes.call( this );
+ delete comparableAttributes.href;
+ return comparableAttributes;
+};
+
/* Registration */
ve.dm.modelRegistry.register( ve.dm.LinkAnnotation );
--
To view, visit https://gerrit.wikimedia.org/r/202015
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I544161a70b15797ae0aab957b8bd61ccfc4e8d54
Gerrit-PatchSet: 1
Gerrit-Project: VisualEditor/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Esanders <esand...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
