jenkins-bot has submitted this change and it was merged. Change subject: Increase values for frequent beta browser tests timeouts ......................................................................
Increase values for frequent beta browser tests timeouts Bug: T94157 Change-Id: Ifad79b74fe2d99fb9fac9ed196e7597d2aff43aa --- M tests/browser/features/step_definitions/mmv_download_steps.rb M tests/browser/features/step_definitions/mmv_steps.rb 2 files changed, 8 insertions(+), 8 deletions(-) Approvals: Gergő Tisza: Looks good to me, approved jenkins-bot: Verified diff --git a/tests/browser/features/step_definitions/mmv_download_steps.rb b/tests/browser/features/step_definitions/mmv_download_steps.rb index 4af5895..1063f2b 100644 --- a/tests/browser/features/step_definitions/mmv_download_steps.rb +++ b/tests/browser/features/step_definitions/mmv_download_steps.rb @@ -11,11 +11,11 @@ When /^I click the download down arrow icon$/ do sleep 1 - on(E2ETestPage).mmv_download_down_arrow_icon_element.when_present.click + on(E2ETestPage).mmv_download_down_arrow_icon_element.when_present(10).click end When /^I click on the attribution area$/ do - on(E2ETestPage).mmv_download_attribution_area_element.when_present.click + on(E2ETestPage).mmv_download_attribution_area_element.when_present(10).click end When /^I click on the attribution area close icon$/ do @@ -48,11 +48,11 @@ end When /^the download menu appears$/ do - on(E2ETestPage).mmv_download_menu_element.when_present + on(E2ETestPage).mmv_download_menu_element.when_present(10) end Then /^the download menu should appear$/ do - expect(on(E2ETestPage).mmv_download_menu_element.when_present).to be_visible + expect(on(E2ETestPage).mmv_download_menu_element.when_present(10)).to be_visible end Then /^the download menu should disappear$/ do @@ -60,7 +60,7 @@ end Then /^the original beginning download image size label should be "(.*)"$/ do |size_in_pixels| - expect(on(E2ETestPage).mmv_download_size_label_element.when_present.text).to eq size_in_pixels + expect(on(E2ETestPage).mmv_download_size_label_element.when_present(10).text).to eq size_in_pixels end Then /^the download image size label should be "(.*)"$/ do |size_in_pixels| @@ -93,7 +93,7 @@ end Then /^the attribution area should be collapsed$/ do - expect(on(E2ETestPage).mmv_download_attribution_area_element.when_present.attribute('class')).to match 'mw-mmv-download-attribution-collapsed' + expect(on(E2ETestPage).mmv_download_attribution_area_element.when_present(10).attribute('class')).to match 'mw-mmv-download-attribution-collapsed' end Then /^the attribution area should be open$/ do diff --git a/tests/browser/features/step_definitions/mmv_steps.rb b/tests/browser/features/step_definitions/mmv_steps.rb index 4edc51c..688421e 100644 --- a/tests/browser/features/step_definitions/mmv_steps.rb +++ b/tests/browser/features/step_definitions/mmv_steps.rb @@ -102,14 +102,14 @@ expect(page.mmv_image_div_element).to be_visible # Check image content - expect(page.mmv_final_image_element.when_present.attribute('src')).to match 'Offsite' + expect(page.mmv_final_image_element.when_present(30).attribute('src')).to match 'Offsite' # Check basic metadata is present # Title expect(page.mmv_metadata_title_element.when_present.text).to match /^Tropical Fish Aquarium$/ # License - expect(page.mmv_metadata_license_element.when_present.attribute('href')).to match /^http:\/\/creativecommons\.org\/licenses\/by-sa\/3\.0$/ + expect(page.mmv_metadata_license_element.when_present(10).attribute('href')).to match /^http:\/\/creativecommons\.org\/licenses\/by-sa\/3\.0$/ expect(page.mmv_metadata_license_element.when_present.text).to match 'CC BY-SA 3.0' # Credit expect(page.mmv_metadata_credit_element.when_present).to be_visible -- To view, visit https://gerrit.wikimedia.org/r/202024 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifad79b74fe2d99fb9fac9ed196e7597d2aff43aa Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/MultimediaViewer Gerrit-Branch: master Gerrit-Owner: Gilles <gdu...@wikimedia.org> Gerrit-Reviewer: Gergő Tisza <gti...@wikimedia.org> Gerrit-Reviewer: MarkTraceur <mtrac...@member.fsf.org> Gerrit-Reviewer: Zfilipin <zfili...@wikimedia.org> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits