jenkins-bot has submitted this change and it was merged. Change subject: Fix Special:EntityData url in dumpRdf and use conceptBaseUri ......................................................................
Fix Special:EntityData url in dumpRdf and use conceptBaseUri the dumps were outputting "http://test.wikidata.org/Special:EntityData"; instead we can construct a title and use getCanonicalURL(), and conceptBaseUri probably should be used here. Change-Id: Id42a35d2503003acb01f33cd41971b1c35f70473 --- M repo/maintenance/dumpRdf.php 1 file changed, 6 insertions(+), 3 deletions(-) Approvals: Hoo man: Looks good to me, approved Smalyshev: Looks good to me, but someone else must approve jenkins-bot: Verified diff --git a/repo/maintenance/dumpRdf.php b/repo/maintenance/dumpRdf.php index 6dde8d2..61f56c7 100644 --- a/repo/maintenance/dumpRdf.php +++ b/repo/maintenance/dumpRdf.php @@ -2,6 +2,7 @@ namespace Wikibase; +use Title; use Wikibase\Dumpers\DumpGenerator; use Wikibase\Dumpers\RdfDumpGenerator; @@ -22,11 +23,13 @@ * @return DumpGenerator */ protected function createDumper( $output ) { - return RdfDumpGenerator::createDumpGenerator( + $entityDataTitle = Title::makeTitle( NS_SPECIAL, 'EntityData' ); + + return RdfDumpGenerator::createDumpGenerator( $this->getOption( 'format', 'ttl' ), $output, - $GLOBALS['wgCanonicalServer']."/entity/", - $GLOBALS['wgCanonicalServer']."/Special:EntityData/", + $this->wikibaseRepo->getSettings()->getSetting( 'conceptBaseUri' ), + $entityDataTitle->getCanonicalURL() . '/', $this->wikibaseRepo->getSiteStore()->getSites(), $this->entityLookup, $this->revisionLookup, $this->wikibaseRepo->getPropertyDataTypeLookup() ); -- To view, visit https://gerrit.wikimedia.org/r/202220 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id42a35d2503003acb01f33cd41971b1c35f70473 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Aude <aude.w...@gmail.com> Gerrit-Reviewer: Aude <aude.w...@gmail.com> Gerrit-Reviewer: Hoo man <h...@online.de> Gerrit-Reviewer: Smalyshev <smalys...@wikimedia.org> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
