jenkins-bot has submitted this change and it was merged.
Change subject: Alpha, beta: Fix page save spinner
......................................................................
Alpha, beta: Fix page save spinner
Apparently, using buttons as icon containers in alpha doesn't work
because the background image is not aligned vertically. Removing the
container and falling back to the default container fixes the problem.
Also, it doesn't make sense to use a button for a spinner. Spinners
are note meant to be clickable.
Bug: T94881
Change-Id: I8ceac6697a435564838c9635d1fdfc0f51b135ff
---
M javascripts/modules/editor/EditorOverlayBase.js
M javascripts/modules/talk/TalkSectionAddOverlay.js
2 files changed, 0 insertions(+), 2 deletions(-)
Approvals:
Jdlrobson: Looks good to me, approved
jenkins-bot: Verified
diff --git a/javascripts/modules/editor/EditorOverlayBase.js
b/javascripts/modules/editor/EditorOverlayBase.js
index cf15bb4..aacce4d 100644
--- a/javascripts/modules/editor/EditorOverlayBase.js
+++ b/javascripts/modules/editor/EditorOverlayBase.js
@@ -52,7 +52,6 @@
waitMsg: mw.msg( 'mobile-frontend-editor-wait' ),
// icons.spinner can't be used, the spinner class
changes to display:none in onStageChanges
waitIcon: new Icon( {
- tagName: 'button',
name: 'spinner',
additionalClassNames: 'savespinner loading'
} ).toHtmlString(),
diff --git a/javascripts/modules/talk/TalkSectionAddOverlay.js
b/javascripts/modules/talk/TalkSectionAddOverlay.js
index 74bf7ea..226a2a0 100644
--- a/javascripts/modules/talk/TalkSectionAddOverlay.js
+++ b/javascripts/modules/talk/TalkSectionAddOverlay.js
@@ -34,7 +34,6 @@
waitMsg: mw.msg( 'mobile-frontend-talk-topic-wait' ),
// icons.spinner can't be used, .loading has a fixed
height, which breaks overlay-header
waitIcon: new Icon( {
- tagName: 'button',
name: 'spinner',
additionalClassNames: 'savespinner loading'
} ).toHtmlString()
--
To view, visit https://gerrit.wikimedia.org/r/202288
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8ceac6697a435564838c9635d1fdfc0f51b135ff
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Bmansurov <[email protected]>
Gerrit-Reviewer: Jdlrobson <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
