Yuvipanda has uploaded a new change for review.
https://gerrit.wikimedia.org/r/202343
Change subject: Rename service monitor to web service monitor
......................................................................
Rename service monitor to web service monitor
It handles only web services!
Also rename and simplify the graphite metric names
Change-Id: Iee1a0f8e79fbc67b6bb7464fc24c76d2bc4f074f
---
R tools/manifest/webservicemonitor.py
1 file changed, 6 insertions(+), 9 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/operations/software/tools-manifest
refs/changes/43/202343/1
diff --git a/tools/manifest/servicemonitor.py
b/tools/manifest/webservicemonitor.py
similarity index 78%
rename from tools/manifest/servicemonitor.py
rename to tools/manifest/webservicemonitor.py
index 121bb17..1819073 100644
--- a/tools/manifest/servicemonitor.py
+++ b/tools/manifest/webservicemonitor.py
@@ -5,10 +5,7 @@
import xml.etree.ElementTree as ET
-class ServiceMonitor(ManifestCollector):
- def _webjob_name(self, manifest):
- return '%s-%s' % (manifest.webservice_server, manifest.tool.name)
-
+class WebServiceMonitor(ManifestCollector):
def _start_webservice(self, manifest):
self.log.info('Starting webservice for tool %s', manifest.tool.name)
try:
@@ -24,10 +21,10 @@
return True
except subprocess.CalledProcessError:
self.log.exception('Could not start webservice for tool %s',
manifest.tool.name)
- self.stats.incr('webservice_startfailed')
+ self.stats.incr('startfailed')
except subprocess.TimeoutExpired:
self.log.exception('Could not start webservice in time for tool
%s', manifest.tool.name)
- self.stats.incr('webservice_startfailed')
+ self.stats.incr('startfailed')
def run(self):
qstat_xml = ET.fromstring(subprocess.check_output(['/usr/bin/qstat',
'-u', '*', '-xml']))
@@ -35,16 +32,16 @@
for manifest in self.manifests:
if manifest.webservice_server is None:
continue
- job = qstat_xml.find('.//job_list[JB_name="%s"]' %
self._webjob_name(manifest))
+ job = qstat_xml.find('.//job_list[JB_name="%s-%s"]' %
(manifest.webservice_server, manifest.tool.name))
if job is None or 'r' not in job.findtext('.//state'):
manifest.tool.log('No running webservice job found, starting
it')
if self._start_webservice(manifest):
restarts_count += 1
self.log.info('Service monitor run completed, %s webservices
restarted', restarts_count)
- self.stats.incr('webservices_restarted', restarts_count)
+ self.stats.incr('startsuccess', restarts_count)
if __name__ == '__main__':
- sm = ServiceMonitor()
+ sm = WebServiceMonitor()
sm.collect()
sm.run()
--
To view, visit https://gerrit.wikimedia.org/r/202343
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iee1a0f8e79fbc67b6bb7464fc24c76d2bc4f074f
Gerrit-PatchSet: 1
Gerrit-Project: operations/software/tools-manifest
Gerrit-Branch: master
Gerrit-Owner: Yuvipanda <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
