jenkins-bot has submitted this change and it was merged.
Change subject: Fix wrong message in LabelDescriptionDuplicateDetector
......................................................................
Fix wrong message in LabelDescriptionDuplicateDetector
Change-Id: Ibde8f425a32f61cb73e606c2e6c034f2196de3d2
---
M repo/includes/LabelDescriptionDuplicateDetector.php
1 file changed, 3 insertions(+), 4 deletions(-)
Approvals:
JanZerebecki: Looks good to me, approved
jenkins-bot: Verified
diff --git a/repo/includes/LabelDescriptionDuplicateDetector.php
b/repo/includes/LabelDescriptionDuplicateDetector.php
index 113bbfc..12eecb7 100644
--- a/repo/includes/LabelDescriptionDuplicateDetector.php
+++ b/repo/includes/LabelDescriptionDuplicateDetector.php
@@ -64,7 +64,7 @@
EntityId $ignoreEntityId = null
) {
if ( !is_string( $entityType ) ) {
- throw new InvalidArgumentException( '$labels must be an
array' );
+ throw new InvalidArgumentException( '$entityType must
be a string' );
}
if ( empty( $labels ) && empty( $descriptions ) ) {
@@ -102,12 +102,11 @@
* @param string $errorCode Error code (for later localization)
* @param Term[] $terms The conflicting terms.
*
- * @return array
+ * @return UniquenessViolation[]
*/
- private function termsToErrors( $message, $errorCode, $terms ) {
+ private function termsToErrors( $message, $errorCode, array $terms ) {
$errors = array();
- /* @var Term $term */
foreach ( $terms as $term ) {
$errors[] = new UniquenessViolation(
$term->getEntityId(),
--
To view, visit https://gerrit.wikimedia.org/r/202384
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibde8f425a32f61cb73e606c2e6c034f2196de3d2
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Thiemo Mättig (WMDE) <thiemo.maet...@wikimedia.de>
Gerrit-Reviewer: Hoo man <h...@online.de>
Gerrit-Reviewer: JanZerebecki <jan.wikime...@zerebecki.de>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
