Anomie has uploaded a new change for review.
https://gerrit.wikimedia.org/r/202603
Change subject: AdHocDebug: Get stack traces for failures in
Article::fetchContentObject
......................................................................
AdHocDebug: Get stack traces for failures in Article::fetchContentObject
It seems that something is somehow occasionally getting into this method
in a state where missing-revision will be returned and cached. Let's log
the failures so we can hopefully find out where that is.
Bug: T92046
Change-Id: Iaf90f6170dd970ec082ea3d0b50b015972dd7227
(cherry picked from commit bfbb3951581a365b34824b4d5d44d853f0448503)
---
M includes/page/Article.php
1 file changed, 6 insertions(+), 0 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/03/202603/1
diff --git a/includes/page/Article.php b/includes/page/Article.php
index 91e9971..b92e8aa 100644
--- a/includes/page/Article.php
+++ b/includes/page/Article.php
@@ -394,6 +394,8 @@
if ( !$oldid ) {
wfDebug( __METHOD__ . " failed to find page
data for title " .
$this->getTitle()->getPrefixedText() .
"\n" );
+ wfDebugLog( 'AdHocDebug', "T92046: failed to
find page data for title " .
+ $this->getTitle()->getPrefixedText() .
": " . wfGetAllCallers( false ) );
return false;
}
@@ -404,6 +406,8 @@
if ( !$this->mRevision ) {
wfDebug( __METHOD__ . " failed to retrieve
current page, rev_id $oldid\n" );
+ wfDebugLog( 'AdHocDebug', "T92046: failed to
fetch Revision for $oldid: " .
+ wfGetAllCallers( false ) );
return false;
}
}
@@ -419,6 +423,8 @@
if ( !$content ) {
wfDebug( __METHOD__ . " failed to retrieve content of
revision " .
$this->mRevision->getId() . "\n" );
+ wfDebugLog( 'AdHocDebug', "T92046: failed to fetch
content of revision " .
+ $this->mRevision->getId() . ": " .
wfGetAllCallers( false ) );
return false;
}
--
To view, visit https://gerrit.wikimedia.org/r/202603
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iaf90f6170dd970ec082ea3d0b50b015972dd7227
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: wmf/1.25wmf24
Gerrit-Owner: Anomie <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
