jenkins-bot has submitted this change and it was merged.

Change subject: [IMPROV] site tests: More debug output
......................................................................


[IMPROV] site tests: More debug output

To further hunt down T92856 it is now outputing the symmetric
difference. That way it's possible to determine if the same page but
with a different 'case' is in the other set. It also explicitly states
the namespaces it uses.

Change-Id: Ib55b4927712400fda0fb16f6af272da0f977e21f
---
M tests/site_tests.py
1 file changed, 7 insertions(+), 0 deletions(-)

Approvals:
  John Vandenberg: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/tests/site_tests.py b/tests/site_tests.py
index 762f91f..c7b2c90 100644
--- a/tests/site_tests.py
+++ b/tests/site_tests.py
@@ -369,6 +369,13 @@
         # TODO: There have been build failures because the following assertion
         # wasn't true. Bug: T92856
         # Example: 
https://travis-ci.org/wikimedia/pywikibot-core/jobs/54552081#L505
+        namespace_links = set(mysite.pagelinks(mainpage, namespaces=[0, 1]))
+        if namespace_links - links:
+            print('FAILURE wrt T92856:')
+            print(u'Sym. difference: "{0}"'.format(
+                  u'", "'.join(
+                  u'{0}@{1}'.format(link.namespace, link.title)
+                  for link in namespace_links ^ links)))
         self.assertCountEqual(
             set(mysite.pagelinks(mainpage, namespaces=[0, 1])) - links, [])
         for target in mysite.preloadpages(mysite.pagelinks(mainpage,

-- 
To view, visit https://gerrit.wikimedia.org/r/198172
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ib55b4927712400fda0fb16f6af272da0f977e21f
Gerrit-PatchSet: 1
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Owner: XZise <[email protected]>
Gerrit-Reviewer: John Vandenberg <[email protected]>
Gerrit-Reviewer: Ladsgroup <[email protected]>
Gerrit-Reviewer: Merlijn van Deen <[email protected]>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to