Faidon Liambotis has submitted this change and it was merged.
Change subject: graphite: fix carbon-relay queue check
......................................................................
graphite: fix carbon-relay queue check
< godog> paravoid: afaict because fullQueueDrops isn't pushed as 0
by carbon-cache when nothing happens, thus no datapoints, not sure
there's a good solution using check_graphite
Use the transformNull() function to transform nulls into 0s.
Change-Id: Icb24dd173a614db0e0282098b8accd483755b5a2
---
M modules/graphite/manifests/monitoring/graphite.pp
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Faidon Liambotis: Looks good to me, approved
jenkins-bot: Verified
diff --git a/modules/graphite/manifests/monitoring/graphite.pp
b/modules/graphite/manifests/monitoring/graphite.pp
index 0d4da01..9775ef8 100644
--- a/modules/graphite/manifests/monitoring/graphite.pp
+++ b/modules/graphite/manifests/monitoring/graphite.pp
@@ -10,7 +10,7 @@
# is carbon-relay queue full? (i.e. dropping data)
monitoring::graphite_threshold { 'carbon-relay_queue_full':
description => 'carbon-relay queue full',
- metric =>
'sumSeries(carbon.relays.graphite1001-*.destinations.*.fullQueueDrops)',
+ metric =>
'sumSeries(transformNull(carbon.relays.graphite1001-*.destinations.*.fullQueueDrops))',
from => '10minutes',
warning => 200,
critical => 1000,
--
To view, visit https://gerrit.wikimedia.org/r/202677
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Icb24dd173a614db0e0282098b8accd483755b5a2
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Faidon Liambotis <fai...@wikimedia.org>
Gerrit-Reviewer: Faidon Liambotis <fai...@wikimedia.org>
Gerrit-Reviewer: Filippo Giunchedi <fgiunch...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
