Mhurd has uploaded a new change for review.
https://gerrit.wikimedia.org/r/203465
Change subject: Quick follow-on optimization to image scroll transform.
......................................................................
Quick follow-on optimization to image scroll transform.
Change-Id: I04589cd9c67c540b630f4dfac2df2056b230c00c
---
M Wikipedia/assets/bundle.js
M www/js/transforms.js
2 files changed, 8 insertions(+), 4 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/apps/ios/wikipedia
refs/changes/65/203465/1
diff --git a/Wikipedia/assets/bundle.js b/Wikipedia/assets/bundle.js
index d029825..23d1589 100644
--- a/Wikipedia/assets/bundle.js
+++ b/Wikipedia/assets/bundle.js
@@ -707,8 +707,10 @@
var div = document.createElement( 'div' );
div.className = 'image_overflow_x_container';
image.parentElement.insertBefore( div, image );
- var oldImage = image.parentElement.removeChild( image );
- div.appendChild( oldImage );
+ // Reminder: appendChild removes "image" from its previous location
+ // so no need to do so explicitly.
+ // See:
https://developer.mozilla.org/en-US/docs/Web/API/Node/appendChild
+ div.appendChild( image );
}
}
diff --git a/www/js/transforms.js b/www/js/transforms.js
index 9de0e91..e95aafb 100644
--- a/www/js/transforms.js
+++ b/www/js/transforms.js
@@ -260,8 +260,10 @@
var div = document.createElement( 'div' );
div.className = 'image_overflow_x_container';
image.parentElement.insertBefore( div, image );
- var oldImage = image.parentElement.removeChild( image );
- div.appendChild( oldImage );
+ // Reminder: appendChild removes "image" from its previous location
+ // so no need to do so explicitly.
+ // See:
https://developer.mozilla.org/en-US/docs/Web/API/Node/appendChild
+ div.appendChild( image );
}
}
--
To view, visit https://gerrit.wikimedia.org/r/203465
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I04589cd9c67c540b630f4dfac2df2056b230c00c
Gerrit-PatchSet: 1
Gerrit-Project: apps/ios/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Mhurd <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
