Catrope has uploaded a new change for review.
https://gerrit.wikimedia.org/r/203472
Change subject: Don't assume ve.compareDocumentOrder() will return exactly 1
......................................................................
Don't assume ve.compareDocumentOrder() will return exactly 1
According to its documentation (and gleaned from its implementation),
it can return any positive number to indicate forward direction.
Change-Id: I74fffc118bbae6350be9fa790116c1e0a0123ebe
---
M src/ce/ve.ce.Surface.js
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/VisualEditor/VisualEditor
refs/changes/72/203472/1
diff --git a/src/ce/ve.ce.Surface.js b/src/ce/ve.ce.Surface.js
index c08c8a0..ddad95c 100644
--- a/src/ce/ve.ce.Surface.js
+++ b/src/ce/ve.ce.Surface.js
@@ -3021,7 +3021,7 @@
);
}
newRange = (
- afterDirection === 1 ?
+ afterDirection > 0 ?
viewNode.getOuterRange() :
viewNode.getOuterRange().flip()
);
--
To view, visit https://gerrit.wikimedia.org/r/203472
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I74fffc118bbae6350be9fa790116c1e0a0123ebe
Gerrit-PatchSet: 1
Gerrit-Project: VisualEditor/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Catrope <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
