Dr0ptp4kt has submitted this change and it was merged.
Change subject: Fix for image info pagination crash.
......................................................................
Fix for image info pagination crash.
T95601
Change-Id: I64af332e4e150893311159100d9662cca6896631
---
M Wikipedia/View Controllers/Image Gallery/WMFImageInfoController.m
1 file changed, 3 insertions(+), 1 deletion(-)
Approvals:
Dr0ptp4kt: Looks good to me, approved
Fjalapeno: Looks good to me, but someone else must approve
jenkins-bot: Verified
diff --git a/Wikipedia/View Controllers/Image Gallery/WMFImageInfoController.m
b/Wikipedia/View Controllers/Image Gallery/WMFImageInfoController.m
index 10b52a7..dd01da9 100644
--- a/Wikipedia/View Controllers/Image Gallery/WMFImageInfoController.m
+++ b/Wikipedia/View Controllers/Image Gallery/WMFImageInfoController.m
@@ -146,7 +146,9 @@
#pragma mark - Private Fetch
- (NSRange)batchRangeForTargetIndex:(NSUInteger)index {
- NSParameterAssert(index < self.uniqueArticleImages.count);
+ if (index > self.uniqueArticleImages.count) {
+ return WMFRangeMakeNotFound();
+ }
NSUInteger const start = floorf(index / (float)self.infoBatchSize) *
self.infoBatchSize;
NSRange const range = NSMakeRange(start, MIN(self.infoBatchSize,
self.uniqueArticleImages.count - start));
NSParameterAssert(range.location <= index);
--
To view, visit https://gerrit.wikimedia.org/r/203197
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I64af332e4e150893311159100d9662cca6896631
Gerrit-PatchSet: 1
Gerrit-Project: apps/ios/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Mhurd <[email protected]>
Gerrit-Reviewer: Bgerstle <[email protected]>
Gerrit-Reviewer: Dr0ptp4kt <[email protected]>
Gerrit-Reviewer: Fjalapeno <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
