jenkins-bot has submitted this change and it was merged.
Change subject: Have phpunit.php exit with 1 in case it couldn't run the tests
......................................................................
Have phpunit.php exit with 1 in case it couldn't run the tests
Just makes more sense not to claim we could complete everything
if we actually couldn't.
Change-Id: I4ec3a2da8913ca546782919813eb18a05a5cca0a
---
M tests/phpunit/phpunit.php
1 file changed, 4 insertions(+), 2 deletions(-)
Approvals:
Aude: Looks good to me, approved
jenkins-bot: Verified
diff --git a/tests/phpunit/phpunit.php b/tests/phpunit/phpunit.php
index e59b506..d18ab73 100755
--- a/tests/phpunit/phpunit.php
+++ b/tests/phpunit/phpunit.php
@@ -228,12 +228,14 @@
}
if ( !$ok ) {
- die( "Couldn't find a usable PHPUnit.\n" );
+ echo "Couldn't find a usable PHPUnit.\n";
+ exit( 1 );
}
$puVersion = PHPUnit_Runner_Version::id();
if ( $puVersion !== '@package_version@' && version_compare( $puVersion,
'3.7.0', '<' ) ) {
- die( "PHPUnit 3.7.0 or later required; you have {$puVersion}.\n" );
+ echo "PHPUnit 3.7.0 or later required; you have {$puVersion}.\n";
+ exit( 1 );
}
PHPUnit_TextUI_Command::main();
--
To view, visit https://gerrit.wikimedia.org/r/203006
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4ec3a2da8913ca546782919813eb18a05a5cca0a
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Hoo man <[email protected]>
Gerrit-Reviewer: Addshore <[email protected]>
Gerrit-Reviewer: Aude <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
