jenkins-bot has submitted this change and it was merged.
Change subject: Don't add empty title tags if no page title set
......................................................................
Don't add empty title tags if no page title set
Change-Id: I9a9e0fa3f0e0bd5c87b567e95d360c7ab67bd4d2
---
M includes/skins/SkinMinerva.php
1 file changed, 5 insertions(+), 2 deletions(-)
Approvals:
Jdlrobson: Looks good to me, approved
jenkins-bot: Verified
diff --git a/includes/skins/SkinMinerva.php b/includes/skins/SkinMinerva.php
index 4a38c9a..f768211 100644
--- a/includes/skins/SkinMinerva.php
+++ b/includes/skins/SkinMinerva.php
@@ -621,8 +621,11 @@
* @returns {String} html for header
*/
protected function getHeaderHtml() {
- return Html::rawElement( 'h1', array( 'id' => 'section_0' ),
- $this->getOutput()->getPageTitle() );
+ $title = $this->getOutput()->getPageTitle();
+ if ( $title ) {
+ return Html::rawElement( 'h1', array( 'id' =>
'section_0' ), $title );
+ }
+ return '';
}
/**
* Create and prepare header and footer content
--
To view, visit https://gerrit.wikimedia.org/r/203099
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9a9e0fa3f0e0bd5c87b567e95d360c7ab67bd4d2
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Florianschmidtwelzow <[email protected]>
Gerrit-Reviewer: Jdlrobson <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
