jenkins-bot has submitted this change and it was merged.
Change subject: Repair pages not being created as expected
......................................................................
Repair pages not being created as expected
A recent refactor in I3497b8 changed BoardContentHandler::canBeUsedOn() to only
check
the list of explicitly allowed new pages, rather than it previously checking
both the
allowed new pages and the currently enabled pages. This has caused a bug where
newly
created pages via $wgFlowOccupyNamespaces are not being written to the page
table. We
will need to revisit and make this entire process more straight forward by
removing
much of the now vestigial occupy code, but as a stop-gap measure this brings
back
checking isTalkpageOccupied() from BoardContentHanlder::canBeUsedOn().
Bug: T95581
Change-Id: I0012f3c3e48b575326ca8a3342691e819d24ae06
---
M includes/Content/BoardContentHandler.php
1 file changed, 2 insertions(+), 1 deletion(-)
Approvals:
Sbisson: Looks good to me, but someone else must approve
Mattflaschen: Looks good to me, approved
jenkins-bot: Verified
diff --git a/includes/Content/BoardContentHandler.php
b/includes/Content/BoardContentHandler.php
index a028251..1f15942 100644
--- a/includes/Content/BoardContentHandler.php
+++ b/includes/Content/BoardContentHandler.php
@@ -102,7 +102,8 @@
public function canBeUsedOn( \Title $title ) {
/** @var \Flow\TalkpageManager $manager */
$manager = Container::get( 'occupation_controller' );
- return $manager->canBeUsedOn( $title );
+ return $manager->canBeUsedOn( $title )
+ || $manager->isTalkpageOccupied( $title );
}
/**
--
To view, visit https://gerrit.wikimedia.org/r/203188
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0012f3c3e48b575326ca8a3342691e819d24ae06
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/Flow
Gerrit-Branch: master
Gerrit-Owner: EBernhardson <[email protected]>
Gerrit-Reviewer: Mattflaschen <[email protected]>
Gerrit-Reviewer: Sbisson <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
