Hashar has uploaded a new change for review. https://gerrit.wikimedia.org/r/203228
Change subject: package_builder: fix dependency order for hooks ...................................................................... package_builder: fix dependency order for hooks On labs the D01.apt.wikimedia.org was never released because the parent directory creation depended on the file being created! Per doc at: https://docs.puppetlabs.com/puppet/latest/reference/lang_relationships.html#chaining-arrows -> (ordering arrow) Causes the resource on the left to be applied before the resource on the right. Written with a hyphen and a greater-than sign. Flip the dependencies to have the directory created before the file. Change-Id: Iaf195dbfd4f657e3743505fa2eb80d778f4b33a6 --- M modules/package_builder/manifests/pbuilder_hook.pp 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/operations/puppet refs/changes/28/203228/1 diff --git a/modules/package_builder/manifests/pbuilder_hook.pp b/modules/package_builder/manifests/pbuilder_hook.pp index 2e1ccb4..5b1f383 100644 --- a/modules/package_builder/manifests/pbuilder_hook.pp +++ b/modules/package_builder/manifests/pbuilder_hook.pp @@ -21,5 +21,5 @@ } # Dependency info - File["${basepath}/hooks/${distribution}/D01apt.wikimedia.org"] -> File["${basepath}/hooks/${distribution}"] + File["${basepath}/hooks/${distribution}"] -> File["${basepath}/hooks/${distribution}/D01apt.wikimedia.org"] } -- To view, visit https://gerrit.wikimedia.org/r/203228 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Iaf195dbfd4f657e3743505fa2eb80d778f4b33a6 Gerrit-PatchSet: 1 Gerrit-Project: operations/puppet Gerrit-Branch: production Gerrit-Owner: Hashar <[email protected]> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
