Hashar has uploaded a new change for review.
https://gerrit.wikimedia.org/r/203198
Change subject: package_builder: use ensure_packages()
......................................................................
package_builder: use ensure_packages()
Puppet package {} causes duplicate definition errors whenever the
package_builder module is used in conjunction with others. I have hit
the wall because of the 'zip' package.
Change package {} to ensure_packages().
Change-Id: I3369a68f10edfa0f7fdb71ede98f075ee555daa5
---
M modules/package_builder/manifests/init.pp
1 file changed, 2 insertions(+), 4 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/operations/puppet
refs/changes/98/203198/1
diff --git a/modules/package_builder/manifests/init.pp
b/modules/package_builder/manifests/init.pp
index c934d8f..f450c97 100644
--- a/modules/package_builder/manifests/init.pp
+++ b/modules/package_builder/manifests/init.pp
@@ -15,7 +15,7 @@
include package_builder::hooks
include package_builder::environments
- package { [
+ ensure_packages([
'cowbuilder',
'build-essential',
'fakeroot',
@@ -28,9 +28,7 @@
'unzip',
'debian-archive-keyring',
'ubuntu-archive-keyring',
- ]:
- ensure => present,
- }
+ ])
file { '/etc/pbuilderrc':
ensure => present,
--
To view, visit https://gerrit.wikimedia.org/r/203198
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3369a68f10edfa0f7fdb71ede98f075ee555daa5
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Hashar <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
