Yuvipanda has submitted this change and it was merged.
Change subject: tools: Do not allow jlocal in crontab
......................................................................
tools: Do not allow jlocal in crontab
No idea why it was allowed, it was a shell script that basically
the same as local execution.
Bug: T95796
Change-Id: I29b67875446f97f6bfc4c40910bc1b369d3f91a8
---
M modules/toollabs/templates/crontab.erb
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Yuvipanda: Verified; Looks good to me, approved
diff --git a/modules/toollabs/templates/crontab.erb
b/modules/toollabs/templates/crontab.erb
index dbd056e..7290e48 100755
--- a/modules/toollabs/templates/crontab.erb
+++ b/modules/toollabs/templates/crontab.erb
@@ -179,7 +179,7 @@
$prefix = "$1 $2 ";
$cmd = $3;
}
- unless($cmd =~
m[^\s*(/usr/(local/)?bin/)?(jsub|jstart|jmail|qsub|jlocal)\s+]) {
+ unless($cmd =~
m[^\s*(/usr/(local/)?bin/)?(jsub|jstart|jmail|qsub)\s+]) {
$cmd = "$prefix/usr/bin/jsub -N cron-$uname-$crlino -once
-quiet $cmd";
$modified = 1;
$line = "$sched $cmd ";
--
To view, visit https://gerrit.wikimedia.org/r/203510
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I29b67875446f97f6bfc4c40910bc1b369d3f91a8
Gerrit-PatchSet: 2
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Yuvipanda <[email protected]>
Gerrit-Reviewer: Yuvipanda <[email protected]>
Gerrit-Reviewer: coren <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
