Tamslo has uploaded a new change for review. https://gerrit.wikimedia.org/r/203792
Change subject: Began to implement violations table ...................................................................... Began to implement violations table Added hook, name constant for table, sql script, class Violation which currently is just kind of a datatype and class ViolationStore which shall be used to insert, update and delete violations from the table (not tested!). Implemented and tested Violation, ViolationStore and ViolationLookup Change-Id: I3040d1d1980b278c63d3c120a5f99f9e3212ea65 --- M .gitignore A .travis.yml M README.md M WikidataQuality.alias.php M WikidataQuality.php M WikidataQualityHooks.php A build/travis/after_script.sh A build/travis/before_script.sh A build/travis/script.sh M composer.json A constraint-report/includes/ConstraintCheck/Checker/CommonsLinkChecker.php A constraint-report/includes/ConstraintCheck/Checker/ConnectionChecker.php A constraint-report/includes/ConstraintCheck/Checker/FormatChecker.php A constraint-report/includes/ConstraintCheck/Checker/OneOfChecker.php A constraint-report/includes/ConstraintCheck/Checker/QualifierChecker.php A constraint-report/includes/ConstraintCheck/Checker/RangeChecker.php A constraint-report/includes/ConstraintCheck/Checker/TypeChecker.php A constraint-report/includes/ConstraintCheck/Checker/ValueCountChecker.php A constraint-report/includes/ConstraintCheck/ConstraintChecker.php A constraint-report/includes/ConstraintCheck/Helper/ConstraintReportHelper.php A constraint-report/includes/ConstraintCheck/Result/CheckResult.php A constraint-report/specials/SpecialConstraintReport.php D constraint-report/specials/SpecialWikidataConstraintReport.php D constraint-report/sql/create_wbq_constraints_from_templates.sql A constraint-report/sql/create_wdq_constraints.sql A constraint-report/tests/phpunit/Checker/CommonsLinkChecker/CommonsLinkCheckerTest.php A constraint-report/tests/phpunit/Checker/ConnectionChecker/ConnectionCheckerTest.php A constraint-report/tests/phpunit/Checker/ConnectionChecker/Q1.json A constraint-report/tests/phpunit/Checker/ConnectionChecker/Q2.json A constraint-report/tests/phpunit/Checker/ConnectionChecker/Q3.json A constraint-report/tests/phpunit/Checker/ConnectionChecker/Q4.json A constraint-report/tests/phpunit/Checker/ConnectionChecker/Q5.json A constraint-report/tests/phpunit/Checker/ConnectionChecker/Q6.json A constraint-report/tests/phpunit/Checker/ConnectionChecker/Q7.json A constraint-report/tests/phpunit/Checker/ConnectionChecker/Q8.json A constraint-report/tests/phpunit/Checker/FormatChecker/FormatCheckerTest.php A constraint-report/tests/phpunit/Checker/OneOfChecker/OneOfCheckerTest.php A constraint-report/tests/phpunit/Checker/QualifierChecker/Q1.json A constraint-report/tests/phpunit/Checker/QualifierChecker/Q2.json A constraint-report/tests/phpunit/Checker/QualifierChecker/Q3.json A constraint-report/tests/phpunit/Checker/QualifierChecker/Q4.json A constraint-report/tests/phpunit/Checker/QualifierChecker/Q5.json A constraint-report/tests/phpunit/Checker/QualifierChecker/QualifierCheckerTest.php A constraint-report/tests/phpunit/Checker/RangeChecker/Q1.json A constraint-report/tests/phpunit/Checker/RangeChecker/Q2.json A constraint-report/tests/phpunit/Checker/RangeChecker/Q3.json A constraint-report/tests/phpunit/Checker/RangeChecker/Q4.json A constraint-report/tests/phpunit/Checker/RangeChecker/Q5.json A constraint-report/tests/phpunit/Checker/RangeChecker/Q6.json A constraint-report/tests/phpunit/Checker/RangeChecker/RangeCheckerTest.php A constraint-report/tests/phpunit/Checker/TypeChecker/Q1.json A constraint-report/tests/phpunit/Checker/TypeChecker/Q2.json A constraint-report/tests/phpunit/Checker/TypeChecker/Q3.json A constraint-report/tests/phpunit/Checker/TypeChecker/Q4.json A constraint-report/tests/phpunit/Checker/TypeChecker/Q5.json A constraint-report/tests/phpunit/Checker/TypeChecker/Q6.json A constraint-report/tests/phpunit/Checker/TypeChecker/TypeCheckerTest.php A constraint-report/tests/phpunit/Checker/ValueCountChecker/Q1.json A constraint-report/tests/phpunit/Checker/ValueCountChecker/Q2.json A constraint-report/tests/phpunit/Checker/ValueCountChecker/Q3.json A constraint-report/tests/phpunit/Checker/ValueCountChecker/Q4.json A constraint-report/tests/phpunit/Checker/ValueCountChecker/Q5.json A constraint-report/tests/phpunit/Checker/ValueCountChecker/Q6.json A constraint-report/tests/phpunit/Checker/ValueCountChecker/ValueCountCheckerTest.php A constraint-report/tests/phpunit/ConstraintCheckerTest.php A constraint-report/tests/phpunit/Helper/ConstraintReportHelperTest.php A constraint-report/tests/phpunit/Q1.json A constraint-report/tests/phpunit/Q2.json A constraint-report/tests/phpunit/Q3.json A constraint-report/tests/phpunit/Q4.json A constraint-report/tests/phpunit/Q5.json A constraint-report/tests/phpunit/Result/CheckResultTest.php A external-validation/api/CrossCheck.php A external-validation/api/Serializer/CrossCheckResultListSerializer.php A external-validation/api/Serializer/CrossCheckResultSerializer.php A external-validation/api/Serializer/DumpMetaInformationSerializer.php A external-validation/includes/CrossCheck/Comparer/DataValueComparer.php A external-validation/includes/CrossCheck/Comparer/EntityIdValueComparer.php A external-validation/includes/CrossCheck/Comparer/GlobeCoordinateValueComparer.php A external-validation/includes/CrossCheck/Comparer/MonolingualTextValueComparer.php A external-validation/includes/CrossCheck/Comparer/MultilingualTextValueComparer.php A external-validation/includes/CrossCheck/Comparer/QuantityValueComparer.php A external-validation/includes/CrossCheck/Comparer/StringValueComparer.php A external-validation/includes/CrossCheck/Comparer/TimeValueComparer.php A external-validation/includes/CrossCheck/CrossChecker.php A external-validation/includes/CrossCheck/ReferenceHandler.php A external-validation/includes/CrossCheck/Result/CompareResult.php A external-validation/includes/CrossCheck/Result/CrossCheckResult.php A external-validation/includes/CrossCheck/Result/CrossCheckResultList.php A external-validation/includes/CrossCheck/Result/ReferenceResult.php A external-validation/includes/DumpMetaInformation.php A external-validation/includes/UpdateTable/ImportContext.php A external-validation/includes/UpdateTable/Importer.php M external-validation/maintenance/UpdateTable.php D external-validation/modules/SpecialCrossCheck.css M external-validation/specials/SpecialCrossCheck.php A external-validation/specials/SpecialExternalDbs.php M external-validation/sql/create_wdq_dump_information.sql M external-validation/sql/create_wdq_external_data.sql D external-validation/src/CrossCheck/Comparer/DataValueComparer.php D external-validation/src/CrossCheck/Comparer/EntityIdValueComparer.php D external-validation/src/CrossCheck/Comparer/MonolingualTextValueComparer.php D external-validation/src/CrossCheck/Comparer/MultilingualTextValueComparer.php D external-validation/src/CrossCheck/Comparer/QuantityValueComparer.php D external-validation/src/CrossCheck/Comparer/StringValueComparer.php D external-validation/src/CrossCheck/Comparer/TimeValueComparer.php D external-validation/src/CrossCheck/CrossChecker.php D external-validation/src/CrossCheck/DumpMetaInformation.php D external-validation/src/CrossCheck/MappingEvaluator/MappingEvaluator.php D external-validation/src/CrossCheck/MappingEvaluator/XPathEvaluator.php D external-validation/src/CrossCheck/Result/CompareResult.php D external-validation/src/CrossCheck/Result/CompareResultList.php D external-validation/src/CrossCheck/mapping.inc.php D external-validation/src/UpdateTable/ImportContext.php D external-validation/src/UpdateTable/Importer/GndImporter.php D external-validation/src/UpdateTable/Importer/Importer.php A external-validation/tests/phpunit/Api/CrossCheckTest.php A external-validation/tests/phpunit/Api/Serializer/CrossCheckResultListSerializerTest.php A external-validation/tests/phpunit/Api/Serializer/CrossCheckResultSerializerTest.php A external-validation/tests/phpunit/Api/Serializer/DumpMetaInformationSerializerTest.php A external-validation/tests/phpunit/CrossCheck/Comparer/DataValueComparerTest.php A external-validation/tests/phpunit/CrossCheck/Comparer/DataValueComparerTestBase.php A external-validation/tests/phpunit/CrossCheck/Comparer/EntityIdValueComparerTest.php A external-validation/tests/phpunit/CrossCheck/Comparer/GlobeCoordinateValueComparerTest.php A external-validation/tests/phpunit/CrossCheck/Comparer/MonolingualTextValueComparerTest.php A external-validation/tests/phpunit/CrossCheck/Comparer/MultilingualTextValueComparerTest.php A external-validation/tests/phpunit/CrossCheck/Comparer/QuantityValueComparerTest.php A external-validation/tests/phpunit/CrossCheck/Comparer/StringValueComparerTest.php A external-validation/tests/phpunit/CrossCheck/Comparer/TimeValueComparerTest.php A external-validation/tests/phpunit/CrossCheck/Comparer/testdata/Q1.json A external-validation/tests/phpunit/CrossCheck/CrossCheckerTest.php A external-validation/tests/phpunit/CrossCheck/Result/CompareResultTest.php A external-validation/tests/phpunit/CrossCheck/Result/CrossCheckResultListTest.php A external-validation/tests/phpunit/CrossCheck/Result/CrossCheckResultTest.php A external-validation/tests/phpunit/CrossCheck/Result/ReferenceResultTest.php A external-validation/tests/phpunit/CrossCheck/testdata/Q1.json A external-validation/tests/phpunit/CrossCheck/testdata/Q2.json A external-validation/tests/phpunit/DumpMetaInformationTest.php A external-validation/tests/phpunit/ReferenceHandlerTest.php A external-validation/tests/phpunit/Specials/SpecialCrossCheckTest.php A external-validation/tests/phpunit/UpdateTable/UpdateTableTest.php A external-validation/tests/phpunit/UpdateTable/testdata/entities.csv A external-validation/tests/phpunit/UpdateTable/testdata/meta.csv M i18n/en.json M i18n/qqq.json A includes/Html/HtmlTable.php A includes/Html/HtmlTableHeader.php A includes/Result/CheckResult.php A includes/Violations/Violation.php A includes/Violations/ViolationLookup.php A includes/Violations/ViolationStore.php A modules/SpecialCheckResultPage.css A phpunit.xml.dist A specials/SpecialCheckResultPage.php A specials/SpecialWikidataQualityPage.php A sql/create_wdqa_violations.sql A tests/bootstrap.php A tests/phpunit/Helper/JsonFileEntityLookup.php A tests/phpunit/Html/HtmlTableTest.php A tests/phpunit/Violation/ViolationLookupTest.php A tests/phpunit/Violation/ViolationStoreTest.php A tests/phpunit/Violation/ViolationTest.php 162 files changed, 14,598 insertions(+), 18,895 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/WikidataQuality refs/changes/92/203792/1 -- To view, visit https://gerrit.wikimedia.org/r/203792 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I3040d1d1980b278c63d3c120a5f99f9e3212ea65 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/WikidataQuality Gerrit-Branch: master Gerrit-Owner: Tamslo <[email protected]> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
