Daniel Kinzler has uploaded a new change for review.
https://gerrit.wikimedia.org/r/203814
Change subject: No user-specific fallback in wbgetentities.
......................................................................
No user-specific fallback in wbgetentities.
The language fallback we offer in the API should (at least per default)
be consistent with the (cacheable) page content we generate. Using different
modes of fallback, some places taking into account languages from Babel boxes,
others now, is confusing.
Change-Id: Ifbf6828a72a80d74ac306d7c24992bdc20d3b918
---
M repo/includes/api/GetEntities.php
1 file changed, 7 insertions(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase
refs/changes/14/203814/1
diff --git a/repo/includes/api/GetEntities.php
b/repo/includes/api/GetEntities.php
index 2e6bd5f..0d819f5 100644
--- a/repo/includes/api/GetEntities.php
+++ b/repo/includes/api/GetEntities.php
@@ -250,13 +250,19 @@
* @return SerializationOptions
*/
private function getSerializationOptions( $params, $props ){
+ $fallbackMode = (
+ LanguageFallbackChainFactory::FALLBACK_VARIANTS
+ | LanguageFallbackChainFactory::FALLBACK_OTHERS
+ | LanguageFallbackChainFactory::FALLBACK_SELF );
+
$options = new SerializationOptions();
+
if ( $params['languagefallback'] ) {
$languages = array();
foreach ( $params['languages'] as $languageCode ) {
// $languageCode is already filtered as valid
ones
$languages[$languageCode] =
$this->languageFallbackChainFactory
- ->newFromContextAndLanguageCode( $this,
$languageCode );
+ ->newFromLanguageCode( $languageCode,
$fallbackMode );
}
} else {
$languages = $params['languages'];
--
To view, visit https://gerrit.wikimedia.org/r/203814
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifbf6828a72a80d74ac306d7c24992bdc20d3b918
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Daniel Kinzler <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
