Matthias Mullie has uploaded a new change for review.
https://gerrit.wikimedia.org/r/203826
Change subject: Get rid of metadataonly entirely
......................................................................
Get rid of metadataonly entirely
Change-Id: Iddd999536d1c37eedf5c61938e0c2b2f4bc66827
---
M includes/Api/ApiFlowBasePost.php
1 file changed, 0 insertions(+), 34 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Flow
refs/changes/26/203826/1
diff --git a/includes/Api/ApiFlowBasePost.php b/includes/Api/ApiFlowBasePost.php
index 5b5e1f7..86cd994 100644
--- a/includes/Api/ApiFlowBasePost.php
+++ b/includes/Api/ApiFlowBasePost.php
@@ -52,27 +52,6 @@
'committed' => $commitMetadata,
) );
- // We used to provide render data along with these POST APIs
because we
- // needed them to render JS. Now we have view-* API's and JS is
using
- // them - we don't need this hack anymore.
- // We'll let this live on for a little while and warn users who
were not
- // already requesting only metadata that this is soon changing.
- if ( $this->getParameter( 'metadataonly' ) !== true ) {
- $output[$action]['result'] = array();
- foreach( $blocksToCommit as $block ) {
- // Always return parsed text to client after
successful submission?
- $output[$action]['result'][$block->getName()] =
$block->renderApi( $params[$block->getName()] );
- }
-
- if ( $this->getParameter( 'metadataonly' ) === null ) {
- $this->setWarning(
- 'This API will soon stop providing
detailed render data in ' .
- 'flow.[action].result. Start getting
that data from view-*' .
- 'API submodules.'
- );
- }
- }
-
// required until php5.4 which has the JsonSerializable
interface
array_walk_recursive( $output, function( &$value ) {
if ( $value instanceof Anchor ) {
@@ -85,19 +64,6 @@
} );
$this->getResult()->addValue( null,
$this->apiFlow->getModuleName(), $output );
- }
-
- public function getAllowedParams() {
- return array(
- 'metadataonly' => array(
- // going to deprecate this (it's becoming
default behavior) and
- // I want to warn people who DON'T set this
param, so I don't
- // want it to default to anything (so I can
check for null)
- // ApiBase::PARAM_TYPE => 'boolean',
- // ApiBase::PARAM_DFLT => false,
- ApiBase::PARAM_REQUIRED => false,
- ),
- );
}
/**
--
To view, visit https://gerrit.wikimedia.org/r/203826
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iddd999536d1c37eedf5c61938e0c2b2f4bc66827
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Flow
Gerrit-Branch: master
Gerrit-Owner: Matthias Mullie <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
