Mhurd has uploaded a new change for review.
https://gerrit.wikimedia.org/r/203887
Change subject: Prevent adding table collapsing chrome around "mbox-small"
tables.
......................................................................
Prevent adding table collapsing chrome around "mbox-small" tables.
"mbox-small" tables are never shown, so don't add table collapsing
chrome around them.
See enwiki "germanic peoples" > "external links" section. There are 2
tables which are hidden, and before this patch they would get wrapped
in table collapsing html, so you have the collapse/expand chrome
appearing around invisible tables.
Change-Id: Ia2cd012e00474e7163c045ea8db67311f45a35e8
---
M Wikipedia/assets/bundle.js
M www/js/transforms.js
2 files changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/apps/ios/wikipedia
refs/changes/87/203887/1
diff --git a/Wikipedia/assets/bundle.js b/Wikipedia/assets/bundle.js
index 23d1589..2e8a9f0 100644
--- a/Wikipedia/assets/bundle.js
+++ b/Wikipedia/assets/bundle.js
@@ -597,7 +597,7 @@
if (findAncestor (tables[i], 'app_table_container')) continue;
//is the table already hidden? if so, don't worry about it
- if (tables[i].style.display === 'none' ||
tables[i].classList.contains( 'navbox' ) || tables[i].classList.contains(
'vertical-navbox' ) || tables[i].classList.contains( 'navbox-inner' ) ||
tables[i].classList.contains( 'metadata' )) {
+ if (tables[i].style.display === 'none' ||
tables[i].classList.contains( 'navbox' ) || tables[i].classList.contains(
'vertical-navbox' ) || tables[i].classList.contains( 'navbox-inner' ) ||
tables[i].classList.contains( 'metadata' ) || tables[i].classList.contains(
'mbox-small' )) {
continue;
}
diff --git a/www/js/transforms.js b/www/js/transforms.js
index e95aafb..7e3b991 100644
--- a/www/js/transforms.js
+++ b/www/js/transforms.js
@@ -150,7 +150,7 @@
if (findAncestor (tables[i], 'app_table_container')) continue;
//is the table already hidden? if so, don't worry about it
- if (tables[i].style.display === 'none' ||
tables[i].classList.contains( 'navbox' ) || tables[i].classList.contains(
'vertical-navbox' ) || tables[i].classList.contains( 'navbox-inner' ) ||
tables[i].classList.contains( 'metadata' )) {
+ if (tables[i].style.display === 'none' ||
tables[i].classList.contains( 'navbox' ) || tables[i].classList.contains(
'vertical-navbox' ) || tables[i].classList.contains( 'navbox-inner' ) ||
tables[i].classList.contains( 'metadata' ) || tables[i].classList.contains(
'mbox-small' )) {
continue;
}
--
To view, visit https://gerrit.wikimedia.org/r/203887
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia2cd012e00474e7163c045ea8db67311f45a35e8
Gerrit-PatchSet: 1
Gerrit-Project: apps/ios/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Mhurd <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
