jenkins-bot has submitted this change and it was merged.
Change subject: Fix jscs coding style issues
......................................................................
Fix jscs coding style issues
Remove unnecessary test method documentation
Change-Id: Ic0f4daea11ee253a6fc30769b1c018f381131426
---
M resources/ext.gather.watchstar/CollectionsContentOverlay.js
M tests/qunit/ext.gather.collection.editor/test_CollectionEditOverlay.js
2 files changed, 1 insertion(+), 6 deletions(-)
Approvals:
Jdlrobson: Looks good to me, approved
jenkins-bot: Verified
diff --git a/resources/ext.gather.watchstar/CollectionsContentOverlay.js
b/resources/ext.gather.watchstar/CollectionsContentOverlay.js
index b7c22fd..86626fa 100644
--- a/resources/ext.gather.watchstar/CollectionsContentOverlay.js
+++ b/resources/ext.gather.watchstar/CollectionsContentOverlay.js
@@ -91,7 +91,7 @@
this.createButton = new ButtonWithSpinner( {
label: mw.msg( 'gather-create-new-button-label'
),
- flags: ['primary', 'constructive']
+ flags: [ 'primary', 'constructive' ]
} );
this.createButton.setDisabled( true );
// Binding here as widgets are not views and are
created after events map runs
diff --git
a/tests/qunit/ext.gather.collection.editor/test_CollectionEditOverlay.js
b/tests/qunit/ext.gather.collection.editor/test_CollectionEditOverlay.js
index 86d1cfd..911c7b9 100644
--- a/tests/qunit/ext.gather.collection.editor/test_CollectionEditOverlay.js
+++ b/tests/qunit/ext.gather.collection.editor/test_CollectionEditOverlay.js
@@ -21,11 +21,6 @@
}
} );
- /**
- * Generate string of a certain length
- * @param {Number} length length of desired string
- * @returns {String} generated string
- */
function getStringWithLength( len ) {
return Array( len + 1 ).join( 'a' );
}
--
To view, visit https://gerrit.wikimedia.org/r/203460
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic0f4daea11ee253a6fc30769b1c018f381131426
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/Gather
Gerrit-Branch: master
Gerrit-Owner: Robmoen <[email protected]>
Gerrit-Reviewer: Jdlrobson <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
