Kaldari has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/203989

Change subject: Prevent database error resulting from duplicate unique key
......................................................................

Prevent database error resulting from duplicate unique key

Bug: T95068
Change-Id: I8420edc8ccea49faae943a90d5c1bf5fc7979905
---
M includes/ResponseStoreDB.php
1 file changed, 2 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/WikiGrok 
refs/changes/89/203989/1

diff --git a/includes/ResponseStoreDB.php b/includes/ResponseStoreDB.php
index 0635e6a..1626410 100644
--- a/includes/ResponseStoreDB.php
+++ b/includes/ResponseStoreDB.php
@@ -90,9 +90,8 @@
                        $nonNewClaims = array();
                        foreach ( $res as $row ) {
                                $claim = $this->rowToClaim( $row );
-                               if ( $claim->status == 'new' ) {
-                                       $claimsFromDb[] = $claim;
-                               } else {
+                               $claimsFromDb[] = $claim;
+                               if ( $claim->status != 'new' ) {
                                        $nonNewClaims[$claim->getKey()] = 1;
                                }
                        }

-- 
To view, visit https://gerrit.wikimedia.org/r/203989
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I8420edc8ccea49faae943a90d5c1bf5fc7979905
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikiGrok
Gerrit-Branch: master
Gerrit-Owner: Kaldari <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to