Aaron Schulz has uploaded a new change for review.
https://gerrit.wikimedia.org/r/203994
Change subject: Avoid outages due to master DB problems in doViewUpdates
......................................................................
Avoid outages due to master DB problems in doViewUpdates
Change-Id: Ie28e8dcfc3bc402b3119d9cf43612acab2af1004
---
M includes/page/WikiPage.php
1 file changed, 6 insertions(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/94/203994/1
diff --git a/includes/page/WikiPage.php b/includes/page/WikiPage.php
index 6242a54..37a01d4 100644
--- a/includes/page/WikiPage.php
+++ b/includes/page/WikiPage.php
@@ -1142,7 +1142,12 @@
}
// Update newtalk / watchlist notification status
- $user->clearNotification( $this->mTitle, $oldid );
+ try {
+ $user->clearNotification( $this->mTitle, $oldid );
+ } catch ( DBError $e ) {
+ // Avoid outage if the master is not reachable
+ MWExceptionHandler::logException( $e );
+ }
}
/**
--
To view, visit https://gerrit.wikimedia.org/r/203994
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie28e8dcfc3bc402b3119d9cf43612acab2af1004
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Aaron Schulz <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
