Mattflaschen has uploaded a new change for review.
https://gerrit.wikimedia.org/r/203998
Change subject: Remove call to processExternalStore from update
......................................................................
Remove call to processExternalStore from update
This is currently broken (it will cause it to point to corrupt NULL
External Store rows), unless you explicitly change the content.
However, we almost never want to change the content anyway. In the
*very* rare case we did (basically the only scenarios we could identify
were cleaning up a Parsoid XSS or fixing T95580 itself), we can do so
by either:
* Using direct DB access (this is how most of our maintenance scripts
work, which is why we didn't get affected by T95580 earlier)
* Adding this back, but obviously only having it change the content
if that is explicitly requested.
Bug: T95869
Change-Id: I0461fd817516d92cf25fc72135fc5471a2ebf643
---
M includes/Data/Storage/RevisionStorage.php
1 file changed, 2 insertions(+), 3 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Flow
refs/changes/98/203998/1
diff --git a/includes/Data/Storage/RevisionStorage.php
b/includes/Data/Storage/RevisionStorage.php
index 97a5c13..71626a5 100644
--- a/includes/Data/Storage/RevisionStorage.php
+++ b/includes/Data/Storage/RevisionStorage.php
@@ -432,13 +432,12 @@
}
// This is to *UPDATE* a revision. It should hardly ever be used.
- // For the most part should insert a new revision. This will only be
called
- // for suppressing?
+ // For the most part should insert a new revision. This should only be
called
+ // by maintenance scripts and (future) suppression features.
public function update( array $old, array $new ) {
$changeSet = $this->calcUpdates( $old, $new );
$rev = $this->splitUpdate( $changeSet, 'rev' );
- $rev = $this->processExternalStore( $rev );
if ( $rev ) {
$dbw = $this->dbFactory->getDB( DB_MASTER );
--
To view, visit https://gerrit.wikimedia.org/r/203998
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0461fd817516d92cf25fc72135fc5471a2ebf643
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Flow
Gerrit-Branch: master
Gerrit-Owner: Mattflaschen <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
