jenkins-bot has submitted this change and it was merged.
Change subject: Remove unused default value
......................................................................
Remove unused default value
The default value is never used, it is overridden in the constructor.
Having it here just misleads someone looking at the code to think it
might pull all columns by default.
Change-Id: I0e743c371d4bd2fab5b89740ba1e0f082512ec34
---
M includes/BatchRowUpdate.php
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Mattflaschen: Looks good to me, approved
jenkins-bot: Verified
diff --git a/includes/BatchRowUpdate.php b/includes/BatchRowUpdate.php
index 8838fca..45f0e1a 100644
--- a/includes/BatchRowUpdate.php
+++ b/includes/BatchRowUpdate.php
@@ -248,7 +248,7 @@
/**
* @var array $fetchColumns List of column names to select from the
table suitable for use with DatabaseBase::select()
*/
- protected $fetchColumns = array( '*' );
+ protected $fetchColumns;
/**
* @var string $orderBy SQL Order by condition generated from
$this->primaryKey
--
To view, visit https://gerrit.wikimedia.org/r/203952
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0e743c371d4bd2fab5b89740ba1e0f082512ec34
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Echo
Gerrit-Branch: master
Gerrit-Owner: EBernhardson <[email protected]>
Gerrit-Reviewer: Mattflaschen <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
