Tamslo has submitted this change and it was merged. Change subject: Database schema updates and bigger refactorings connected with it. ......................................................................
Database schema updates and bigger refactorings connected with it. Changed table prefix to 'wdqa'. Table 'wdq_dump_meta_information' now contains information about single dumps instead of complete databases. License of a dump is saved as corresponding item id. Added 'wdqa_identifier_properties' table as relation between dumps and identifier properties. Table 'wdq_external_data' contains dump ids instead of identifier property ids. Entity ids are now stored as serialization instead of numeric id. Serializers no longer extend deprecated SerializerObject class. Instead they implement Serializer interface from WMDE serialization package. Indexed tags are not supported in new used serializer package. That's why API module 'CrossCheck' is currently not working for xml output. Refactored CheckResults to improve structure and consistency. Moved PropertyId, ClaimGuid and DumpMetaInformation from CompareResult to CrossCheckResult. Removed duplicate getters from CrossCheckResult. Change-Id: I6993a4f42346926d0a2cd78e1bdfa86453352292 --- M WikidataQuality.php M WikidataQualityHooks.php M composer.json M external-validation/api/CrossCheck.php D external-validation/api/Serializer/CrossCheckResultListSerializer.php D external-validation/api/Serializer/CrossCheckResultSerializer.php D external-validation/api/Serializer/DumpMetaInformationSerializer.php M external-validation/includes/CrossCheck/CrossChecker.php M external-validation/includes/CrossCheck/ReferenceHandler.php M external-validation/includes/CrossCheck/Result/CompareResult.php M external-validation/includes/CrossCheck/Result/CrossCheckResult.php M external-validation/includes/CrossCheck/Result/CrossCheckResultList.php M external-validation/includes/CrossCheck/Result/ReferenceResult.php M external-validation/includes/DumpMetaInformation.php A external-validation/includes/Serializer/CompareResultSerializer.php A external-validation/includes/Serializer/CrossCheckResultListSerializer.php A external-validation/includes/Serializer/CrossCheckResultSerializer.php A external-validation/includes/Serializer/DumpMetaInformationSerializer.php A external-validation/includes/Serializer/ReferenceResultSerializer.php A external-validation/includes/Serializer/SerializerFactory.php M external-validation/includes/UpdateTable/ImportContext.php M external-validation/includes/UpdateTable/Importer.php M external-validation/maintenance/UpdateTable.php M external-validation/specials/SpecialCrossCheck.php M external-validation/specials/SpecialExternalDbs.php D external-validation/sql/create_wdq_dump_information.sql D external-validation/sql/create_wdq_external_data.sql A external-validation/sql/create_wdqa_dump_information.sql A external-validation/sql/create_wdqa_external_data.sql A external-validation/sql/create_wdqa_identifier_properties.sql M external-validation/tests/phpunit/Api/CrossCheckTest.php D external-validation/tests/phpunit/Api/Serializer/CrossCheckResultListSerializerTest.php D external-validation/tests/phpunit/Api/Serializer/CrossCheckResultSerializerTest.php D external-validation/tests/phpunit/Api/Serializer/DumpMetaInformationSerializerTest.php M external-validation/tests/phpunit/CrossCheck/CrossCheckerTest.php M external-validation/tests/phpunit/CrossCheck/Result/CompareResultTest.php M external-validation/tests/phpunit/CrossCheck/Result/CrossCheckResultListTest.php M external-validation/tests/phpunit/CrossCheck/Result/CrossCheckResultTest.php M external-validation/tests/phpunit/CrossCheck/Result/ReferenceResultTest.php M external-validation/tests/phpunit/CrossCheck/testdata/Q1.json M external-validation/tests/phpunit/CrossCheck/testdata/Q2.json A external-validation/tests/phpunit/CrossCheck/testdata/Q3.json M external-validation/tests/phpunit/DumpMetaInformationTest.php M external-validation/tests/phpunit/ReferenceHandlerTest.php A external-validation/tests/phpunit/Serializer/CompareResultSerializerTest.php A external-validation/tests/phpunit/Serializer/CrossCheckResultListSerializerTest.php A external-validation/tests/phpunit/Serializer/CrossCheckResultSerializerTest.php A external-validation/tests/phpunit/Serializer/DumpMetaInformationSerializerTest.php A external-validation/tests/phpunit/Serializer/ReferenceResultSerializerTest.php A external-validation/tests/phpunit/Serializer/SerializerBaseTest.php A external-validation/tests/phpunit/Serializer/SerializerFactoryTest.php M external-validation/tests/phpunit/Specials/SpecialCrossCheckTest.php M external-validation/tests/phpunit/Specials/SpecialExternalDbsTest.php M external-validation/tests/phpunit/UpdateTable/UpdateTableTest.php M external-validation/tests/phpunit/UpdateTable/testdata/entities.csv A external-validation/tests/phpunit/UpdateTable/testdata/identifiers.csv M external-validation/tests/phpunit/UpdateTable/testdata/meta.csv M specials/SpecialCheckResultPage.php 58 files changed, 3,484 insertions(+), 2,855 deletions(-) Approvals: Tamslo: Verified; Looks good to me, approved jenkins-bot: Checked -- To view, visit https://gerrit.wikimedia.org/r/203883 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6993a4f42346926d0a2cd78e1bdfa86453352292 Gerrit-PatchSet: 4 Gerrit-Project: mediawiki/extensions/WikidataQuality Gerrit-Branch: master Gerrit-Owner: Soeren.oldag <[email protected]> Gerrit-Reviewer: Legoktm <[email protected]> Gerrit-Reviewer: Springle <[email protected]> Gerrit-Reviewer: Tamslo <[email protected]> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
