jenkins-bot has submitted this change and it was merged.
Change subject: Disable mobile editor for entity pages
......................................................................
Disable mobile editor for entity pages
The removed key prevents resource loader to load modules
for the mobile editor.
Bug: T95880
Change-Id: I52d28a825e02f9307a8a071877d1953f5739839a
---
M repo/Wikibase.hooks.php
M repo/Wikibase.php
2 files changed, 22 insertions(+), 0 deletions(-)
Approvals:
Aude: Looks good to me, approved
jenkins-bot: Verified
diff --git a/repo/Wikibase.hooks.php b/repo/Wikibase.hooks.php
index d64b774..97060e7 100644
--- a/repo/Wikibase.hooks.php
+++ b/repo/Wikibase.hooks.php
@@ -1178,4 +1178,25 @@
return true;
}
+ /**
+ * Disable mobile editor for entity pages in Extension:MobileFrontend.
+ * @see https://www.mediawiki.org/wiki/Extension:MobileFrontend
+ *
+ * @param Skin $skin
+ * @param array &$modules associative array of resource loader modules
+ *
+ * @return bool
+ */
+ public static function onSkinMinervaDefaultModules( Skin $skin, array
&$modules ) {
+ $title = $skin->getTitle();
+ $entityNamespaceLookup =
WikibaseRepo::getDefaultInstance()->getEntityNamespaceLookup();
+
+ // remove the editor module so that it does not get loaded on
entity pages
+ if ( $entityNamespaceLookup->isEntityNamespace(
$title->getNamespace() ) ) {
+ unset( $modules['editor'] );
+ }
+
+ return true;
+ }
+
}
diff --git a/repo/Wikibase.php b/repo/Wikibase.php
index 5a73d8e..6509446 100644
--- a/repo/Wikibase.php
+++ b/repo/Wikibase.php
@@ -226,6 +226,7 @@
$wgHooks['ImportHandleRevisionXMLTag'][] =
'Wikibase\RepoHooks::onImportHandleRevisionXMLTag';
$wgHooks['BaseTemplateToolbox'][] =
'Wikibase\RepoHooks::onBaseTemplateToolbox';
$wgHooks['SkinTemplateBuildNavUrlsNav_urlsAfterPermalink'][] =
'Wikibase\RepoHooks::onSkinTemplateBuildNavUrlsNav_urlsAfterPermalink';
+ $wgHooks['SkinMinervaDefaultModules'][] =
'Wikibase\RepoHooks::onSkinMinervaDefaultModules';
// update hooks
$wgHooks['LoadExtensionSchemaUpdates'][] =
'\Wikibase\Repo\Store\Sql\ChangesSubscriptionSchemaUpdater::onSchemaUpdate';
--
To view, visit https://gerrit.wikimedia.org/r/204024
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I52d28a825e02f9307a8a071877d1953f5739839a
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Bene <[email protected]>
Gerrit-Reviewer: Aude <[email protected]>
Gerrit-Reviewer: Daniel Kinzler <[email protected]>
Gerrit-Reviewer: Florianschmidtwelzow <[email protected]>
Gerrit-Reviewer: Hoo man <[email protected]>
Gerrit-Reviewer: Jeroen De Dauw <[email protected]>
Gerrit-Reviewer: Thiemo Mättig (WMDE) <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
