Niharika29 has uploaded a new change for review.
https://gerrit.wikimedia.org/r/204069
Change subject: Add i18n keys for placeholder strings in Add Campaign page
......................................................................
Add i18n keys for placeholder strings in Add Campaign page
Change-Id: I5b14091c3f5abb07bff9d743156c117558d5cd7c
---
M data/i18n/en.json
M data/i18n/qqq.json
M data/templates/admin/campaign.html
3 files changed, 19 insertions(+), 9 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/wikimedia/iegreview
refs/changes/69/204069/1
diff --git a/data/i18n/en.json b/data/i18n/en.json
index 81005ee..38793d1 100644
--- a/data/i18n/en.json
+++ b/data/i18n/en.json
@@ -111,7 +111,12 @@
"admin-new-campaign-in-progress": "Cannot create a new campaign if one
is already in progress. Please end the current campaign before starting a new
one.",
"admin-campaign-reviewers": "Campaign reviewers:",
"admin-campaign-question": "Question $1:",
- "admin-campaign-question-placeholder": "Add question text here",
+ "admin-campaign-questionbody-placeholder": "Add question text here",
+ "admin-campaign-name-placeholder": "Must be unique",
+ "admin-campaign-date-placeholder": "YYYY-MM-DD HH:MM:SS (UTC only)",
+ "admin-campaign-questiontitle-placeholder": "Add question title here.
For example: Criteria A: Innovation",
+ "admin-campaign-questionfooter-placeholder": "Add question footer
string here",
+ "admin-campaign-reporthead-placeholder": "Aggregated report column
header. For example: Innovation",
"page-of-pages": "Page $1 of $2",
"no-results": "No results found",
diff --git a/data/i18n/qqq.json b/data/i18n/qqq.json
index 736c41e..9c22523 100644
--- a/data/i18n/qqq.json
+++ b/data/i18n/qqq.json
@@ -47,7 +47,12 @@
"admin-new-campaign-in-progress": "Message shown to user when a new
campaign creation fails because an exsting one is in progress",
"admin-campaign-reviewers": "Input label, followed by a checkbox group",
"admin-campaign-question": "Input label, followed by multi-line
textarea. Parameters:\n* $1 - question number",
- "admin-campaign-question-placeholder": "Placeholder text for a
textarea",
+ "admin-campaign-questionbody-placeholder": "Placeholder text for a
textarea",
+ "admin-campaign-name-placeholder": "Placeholder text for an input box",
+ "admin-campaign-date-placeholder": "Placeholder text for an input box",
+ "admin-campaign-questiontitle-placeholder": "Placeholder text for an
input box",
+ "admin-campaign-questionfooter-placeholder": "Placeholder text for an
input box",
+ "admin-campaign-reporthead-placeholder": "Placeholder text for an input
box",
"change-password": "Navigation menu item, links to password change
page.\n{{Identical|Change password}}",
"credits": "Credits page heading",
diff --git a/data/templates/admin/campaign.html
b/data/templates/admin/campaign.html
index 020acf1..878b9de 100644
--- a/data/templates/admin/campaign.html
+++ b/data/templates/admin/campaign.html
@@ -39,7 +39,7 @@
{{ 'admin-campaign-new'|message }}
</label>
<div class="col-sm-6">
- <input type="text" class="form-control" name="name" id="name"
placeholder="Must be unique" value="{{ campaign.name }}" required="required">
+ <input type="text" class="form-control" name="name" id="name"
placeholder="{{ 'admin-campaign-name-placeholder'|message }}" value="{{
campaign.name }}" required="required">
</div>
</div>
@@ -48,7 +48,7 @@
{{ 'admin-campaign-start-date'|message }}
</label>
<div class="col-sm-6">
- <input type="date" class="form-control" name="start_date"
id="start_date" placeholder="YYYY-MM-DD HH:MM:SS (UTC only)" value="{{
campaign.start_date }}" required="required">
+ <input type="date" class="form-control" name="start_date"
id="start_date" placeholder="{{ 'admin-campaign-date-placeholder'|message }}"
value="{{ campaign.start_date }}" required="required">
</div>
</div>
@@ -57,7 +57,7 @@
{{ 'admin-campaign-end-date'|message }}
</label>
<div class="col-sm-6">
- <input type="date" class="form-control" name="end_date" id="end_date"
placeholder="YYYY-MM-DD HH:MM:SS (UTC only)" value="{{ campaign.end_date }}"
required="required">
+ <input type="date" class="form-control" name="end_date" id="end_date"
placeholder="{{ 'admin-campaign-date-placeholder'|message }}" value="{{
campaign.end_date }}" required="required">
</div>
</div>
@@ -67,16 +67,16 @@
{{ 'admin-campaign-question'|message( loop.index ) }}
</label>
<div class="col-sm-10 {{ "qtitles[#{row.id}]" in errors ? 'has-error' }}">
- <input type="text" class="form-control" name="qtitles[{{ row.id }}]"
value="{{ row.question_title }}" placeholder="Add question title here" required>
+ <input type="text" class="form-control" name="qtitles[{{ row.id }}]"
value="{{ row.question_title }}" placeholder="{{
'admin-campaign-questiontitle-placeholder'|message }}" required>
</div>
<div class="col-sm-10 col-sm-offset-2 {{ "questions[#{row.id}]" in errors
? 'has-error' }}">
- <textarea class="form-control" rows="6" name="questions[{{ row.id }}]"
placeholder="{{ 'admin-campaign-question-placeholder'|message }}">{{
row.question_body }}</textarea>
+ <textarea class="form-control" rows="6" name="questions[{{ row.id }}]"
placeholder="{{ 'admin-campaign-questionbody-placeholder'|message }}">{{
row.question_body }}</textarea>
</div>
<div class="col-sm-10 col-sm-offset-2 {{ "qfooters[#{row.id}]" in errors ?
'has-error' }}">
- <input type="text" class="form-control" name="qfooters[{{ row.id }}]"
value="{{ row.question_footer }}" placeholder="Add question footer string here"
required>
+ <input type="text" class="form-control" name="qfooters[{{ row.id }}]"
value="{{ row.question_footer }}" placeholder="{{
'admin-campaign-questionfooter-placeholder'|message }}" required>
</div>
<div class="col-sm-10 col-sm-offset-2 {{ "qreporthead[#{row.id}]" in
errors ? 'has-error' }}">
- <input type="text" class="form-control" name="qreporthead[{{ row.id }}]"
value="{{ row.report_head }}" placeholder="Report column header" required>
+ <input type="text" class="form-control" name="qreporthead[{{ row.id }}]"
value="{{ row.report_head }}" placeholder="{{
'admin-campaign-reporthead-placeholder'|message }}" required>
</div>
</div>
{% endfor %}
--
To view, visit https://gerrit.wikimedia.org/r/204069
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5b14091c3f5abb07bff9d743156c117558d5cd7c
Gerrit-PatchSet: 1
Gerrit-Project: wikimedia/iegreview
Gerrit-Branch: master
Gerrit-Owner: Niharika29 <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
