Bartosz Dziewoński has uploaded a new change for review.
https://gerrit.wikimedia.org/r/204125
Change subject: MenuLayout: Fix initialization order
......................................................................
MenuLayout: Fix initialization order
Constructing a MenuLayout with { showMenu: false } would not correctly
hide the menu (https://phabricator.wikimedia.org/F112876).
Spotted by Kirsten when working on documentation.
Change-Id: I1c42fa4fa79efe023b3652717b3cb8545caeb01a
---
M src/layouts/MenuLayout.js
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/oojs/ui refs/changes/25/204125/1
diff --git a/src/layouts/MenuLayout.js b/src/layouts/MenuLayout.js
index 306eebe..3074f06 100644
--- a/src/layouts/MenuLayout.js
+++ b/src/layouts/MenuLayout.js
@@ -41,8 +41,6 @@
this.$content = $( '<div>' );
// Initialization
- this.toggleMenu( this.showMenu );
- this.updateSizes();
this.$menu
.addClass( 'oo-ui-menuLayout-menu' )
.css( this.menuPosition.sizeProperty, this.menuSize );
@@ -50,6 +48,8 @@
this.$element
.addClass( 'oo-ui-menuLayout ' + this.menuPosition.className )
.append( this.$content, this.$menu );
+ this.toggleMenu( this.showMenu );
+ this.updateSizes();
};
/* Setup */
--
To view, visit https://gerrit.wikimedia.org/r/204125
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1c42fa4fa79efe023b3652717b3cb8545caeb01a
Gerrit-PatchSet: 1
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: Bartosz Dziewoński <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
