Arlolra has uploaded a new change for review.
https://gerrit.wikimedia.org/r/204306
Change subject: Assert body node in serializeDOM
......................................................................
Assert body node in serializeDOM
* This was audited in 0c9d3e12f87a37b0da9c4caa0635ba0792c535d7
Change-Id: I2fcc236d8216d4af4fa6403d1d3e915a1349f26c
---
M lib/mediawiki.SelectiveSerializer.js
M lib/mediawiki.WikitextSerializer.js
2 files changed, 4 insertions(+), 0 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/services/parsoid
refs/changes/06/204306/1
diff --git a/lib/mediawiki.SelectiveSerializer.js
b/lib/mediawiki.SelectiveSerializer.js
index e52f672..d133c3d 100644
--- a/lib/mediawiki.SelectiveSerializer.js
+++ b/lib/mediawiki.SelectiveSerializer.js
@@ -152,6 +152,8 @@
SSP.serializeDOM = function(body, dummy, cb) {
cb = JSUtils.mkPromised(cb);
+ console.assert(DU.isBody(body), "Expected a body node");
+
var self = this;
if ( this.env.page.dom || this.env.page.domdiff ) {
this.doSerializeDOM( null, body, cb );
diff --git a/lib/mediawiki.WikitextSerializer.js
b/lib/mediawiki.WikitextSerializer.js
index 42808e7..773ff4e 100644
--- a/lib/mediawiki.WikitextSerializer.js
+++ b/lib/mediawiki.WikitextSerializer.js
@@ -1369,6 +1369,8 @@
* WARNING: You probably want to use the wrapper below.
*/
WSP._serializeDOM = function(body, selserMode) {
+ console.assert(DU.isBody(body), "Expected a body node");
+
this.logType = selserMode ? "trace/selser" : "trace/wts";
this.trace = this.env.log.bind(this.env, this.logType);
--
To view, visit https://gerrit.wikimedia.org/r/204306
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2fcc236d8216d4af4fa6403d1d3e915a1349f26c
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/services/parsoid
Gerrit-Branch: master
Gerrit-Owner: Arlolra <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
