Fjalapeno has uploaded a new change for review.
https://gerrit.wikimedia.org/r/204651
Change subject: Fix change logs - git not using the proper path to the repo.
......................................................................
Fix change logs - git not using the proper path to the repo.
Change-Id: I3e20c18a8fd38997b9e8dba14880fdfea646c741
---
M fastlane/lib/utils.rb
1 file changed, 9 insertions(+), 8 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/apps/ios/wikipedia
refs/changes/51/204651/1
diff --git a/fastlane/lib/utils.rb b/fastlane/lib/utils.rb
index 9e23a78..f9f55ed 100644
--- a/fastlane/lib/utils.rb
+++ b/fastlane/lib/utils.rb
@@ -50,10 +50,11 @@
# Generate a list of commit subjects from `rev` to `HEAD`
# :rev: The git SHA to start the log from, defaults to `ENV[LAST_SUCCESS_REV']`
-def generate_git_commit_log(rev=ENV['LAST_SUCCESS_REV'])
- g = Git.open(Dir.getwd)
+def generate_git_commit_log(rev=ENV['GIT_PREVIOUS_SUCCESSFUL_COMMIT'])
+ g = Git.open(ENV['PWD'], :log => Logger.new(STDOUT))
change_log = g.log.between(rev).map { |c| "- " + c.message.lines.first.chomp
}.join "\n"
"Commit Log:\n\n#{change_log}\n"
+ p change_log
end
# Memoized version of `generate_git_commit_log` which stores the result in
`ENV['GIT_COMMIT_LOG']`.
@@ -66,17 +67,17 @@
# Upload the DSYM to Hockey
hockey({
api_token: ENV['HOCKEY_API_TOKEN'],
- notes: git_commit_log,
+ notes: '',
notify: 0,
status: 1, #Means do not make available for download
})
- #Set "What To Test" in iTunes Connect for Testflight builds, in the
future, reference tickets instead of git commits
- DELIVER_WHAT_TO_TEST.replace = git_commit_log
- #Set "App Description" in iTunes Connect for Testflight builds, in the
future set a better description
- DELIVER_BETA_DESCRIPTION.replace = git_commit_log
#Set "Feedback email" in iTunes Connect for Testflight builds
- DELIVER_BETA_FEEDBACK_EMAIL.replace = '[email protected]'
+ self.class.const_set("DELIVER_BETA_FEEDBACK_EMAIL", '[email protected]')
+ #Set "What To Test" in iTunes Connect for Testflight builds, in the
future, reference tickets instead of git commits
+ self.class.const_set("DELIVER_WHAT_TO_TEST", git_commit_log)
+ #Set "App Description" in iTunes Connect for Testflight builds, in the
future set a better description
+ self.class.const_set("DELIVER_BETA_DESCRIPTION", git_commit_log)
# Upload the IPA and DSYM to iTunes Connect
deliver :testflight, :beta, :skip_deploy, :force
--
To view, visit https://gerrit.wikimedia.org/r/204651
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3e20c18a8fd38997b9e8dba14880fdfea646c741
Gerrit-PatchSet: 1
Gerrit-Project: apps/ios/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Fjalapeno <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
