Catrope has uploaded a new change for review.
https://gerrit.wikimedia.org/r/204653
Change subject: Remove unused editor switcher CSS
......................................................................
Remove unused editor switcher CSS
There was CSS for .flow-editor-color that expected to be
used for both the WT->VE and VE->WT switch buttons, but
the VE->WT switch button is an OOUI tool now. For the
WT->VE case, it was just duplicating what mw-ui-constructive
already applied, so it was useless.
We need to keep that class though, because it applies float: right;,
but rename it to flow-editor-switcher because the name
flow-editor-color is now a lie.
Change-Id: Ie2171928b70891dd86f1347a4f09c157d20f228c
---
M handlebars/flow_editor_switcher.partial.handlebars
M modules/styles/board/editor-switcher.less
2 files changed, 2 insertions(+), 15 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Flow
refs/changes/53/204653/1
diff --git a/handlebars/flow_editor_switcher.partial.handlebars
b/handlebars/flow_editor_switcher.partial.handlebars
index 812b093..21bda82 100644
--- a/handlebars/flow_editor_switcher.partial.handlebars
+++ b/handlebars/flow_editor_switcher.partial.handlebars
@@ -6,7 +6,7 @@
{{#if enable_switcher}}
<a href="#"
title="{{l10n
"flow-wikitext-switch-editor-tooltip"}}"
- class="mw-ui-button mw-ui-constructive flow-js
flow-editor-color"
+ class="mw-ui-button mw-ui-constructive flow-js
flow-editor-switcher"
data-flow-interactive-handler="switchEditor"
data-flow-target="< form textarea"
>
diff --git a/modules/styles/board/editor-switcher.less
b/modules/styles/board/editor-switcher.less
index d1cdd18..1f0fbec 100644
--- a/modules/styles/board/editor-switcher.less
+++ b/modules/styles/board/editor-switcher.less
@@ -2,19 +2,6 @@
@import 'mediawiki.ui/variables';
@import 'flow.colors';
-// extra specificity is needed to override .mw-ui-button.mw-ui-*
-.mw-ui-button.flow-editor-color {
- .flow-editor-none & {
- color: white;
- background-color: @colorConstructive;
- }
-
- .flow-editor-visualeditor & {
- color: @colorText;
- background-color: white;
- }
-}
-
.flow-editor {
// because we're attaching switcher controls below the textarea & we
// want them to look unified with the textarea, we'll have to take away
@@ -48,7 +35,7 @@
line-height: 1.4;
}
- a.flow-editor-color {
+ a.flow-editor-switcher {
float: right;
}
}
--
To view, visit https://gerrit.wikimedia.org/r/204653
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie2171928b70891dd86f1347a4f09c157d20f228c
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Flow
Gerrit-Branch: master
Gerrit-Owner: Catrope <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
