Tim Landscheidt has uploaded a new change for review. https://gerrit.wikimedia.org/r/204772
Change subject: ocg: Fix ferm rules ...................................................................... ocg: Fix ferm rules $INTERNAL is a reference to a ferm variable and needs to be passed verbatim; the Puppet variable $::INTERNAL is likely unset and thus causes the source range to default to "anywhere". Change-Id: I2c12298a694d1cd1c1ed09eadc5faed765d3aa6d --- M manifests/role/ocg.pp 1 file changed, 3 insertions(+), 3 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/operations/puppet refs/changes/72/204772/1 diff --git a/manifests/role/ocg.pp b/manifests/role/ocg.pp index 86b9105..25f1eef 100644 --- a/manifests/role/ocg.pp +++ b/manifests/role/ocg.pp @@ -41,14 +41,14 @@ proto => 'tcp', port => $::ocg::service_port, desc => 'HTTP frontend to submit jobs and get status from pdf rendering', - srange => $::INTERNAL + srange => '$INTERNAL', } ferm::service{ 'gmond': proto => 'tcp', port => 8649, desc => 'Ganglia monitor port (OCG config)', - srange => $::INTERNAL + srange => '$INTERNAL', } include lvs::configuration @@ -73,7 +73,7 @@ proto => 'tcp', port => $service_port, desc => 'HTTP frontend to submit jobs and get status from pdf rendering', - srange => $::INTERNAL + srange => '$INTERNAL', } class { 'redis': -- To view, visit https://gerrit.wikimedia.org/r/204772 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I2c12298a694d1cd1c1ed09eadc5faed765d3aa6d Gerrit-PatchSet: 1 Gerrit-Project: operations/puppet Gerrit-Branch: production Gerrit-Owner: Tim Landscheidt <t...@tim-landscheidt.de> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits