Soeren.oldag has uploaded a new change for review.
https://gerrit.wikimedia.org/r/205209
Change subject: Made some fixes for sqlite and php 5.3.
......................................................................
Made some fixes for sqlite and php 5.3.
Change-Id: If7c73ce9f6375ee66070ce6e18d1ee3b180d1610
---
M includes/Serializer/CompareResultSerializer.php
M sql/create_wdqa_identifier_properties.sql
2 files changed, 6 insertions(+), 6 deletions(-)
git pull
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/WikidataQualityExternalValidation
refs/changes/09/205209/1
diff --git a/includes/Serializer/CompareResultSerializer.php
b/includes/Serializer/CompareResultSerializer.php
index 89aa48f..e9ca3f9 100644
--- a/includes/Serializer/CompareResultSerializer.php
+++ b/includes/Serializer/CompareResultSerializer.php
@@ -63,9 +63,10 @@
}
private function getSerialized( CompareResult $compareResult ) {
+ $dataValueSerializer = $this->dataValueSerializer;
$externalValues = array_map(
- function ( $dataValue ) {
- return $this->dataValueSerializer->serialize(
$dataValue );
+ function ( $dataValue ) use( $dataValueSerializer ){
+ return $dataValueSerializer->serialize(
$dataValue );
},
$compareResult->getExternalValues()
);
diff --git a/sql/create_wdqa_identifier_properties.sql
b/sql/create_wdqa_identifier_properties.sql
index af0c73e..289b400 100644
--- a/sql/create_wdqa_identifier_properties.sql
+++ b/sql/create_wdqa_identifier_properties.sql
@@ -1,6 +1,5 @@
CREATE TABLE IF NOT EXISTS wdqa_identifier_properties (
identifier_pid VARBINARY(15) NOT NULL,
- dump_id VARBINARY(25) NOT NULL
-);
-
-ALTER TABLE wdqa_identifier_properties ADD PRIMARY KEY (identifier_pid,
dump_id);
\ No newline at end of file
+ dump_id VARBINARY(25) NOT NULL,
+ PRIMARY KEY (identifier_pid, dump_id)
+);
\ No newline at end of file
--
To view, visit https://gerrit.wikimedia.org/r/205209
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: If7c73ce9f6375ee66070ce6e18d1ee3b180d1610
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikidataQualityExternalValidation
Gerrit-Branch: master
Gerrit-Owner: Soeren.oldag <soeren_ol...@freenet.de>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
