Aaron Schulz has uploaded a new change for review.
https://gerrit.wikimedia.org/r/205293
Change subject: BagOStuff doc tweaks
......................................................................
BagOStuff doc tweaks
Change-Id: I0eea84bbbc4c742c07a35a2b157517ad9dd40bb8
---
M includes/libs/objectcache/BagOStuff.php
1 file changed, 5 insertions(+), 3 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/93/205293/1
diff --git a/includes/libs/objectcache/BagOStuff.php
b/includes/libs/objectcache/BagOStuff.php
index 0b791e5..150a7ce 100644
--- a/includes/libs/objectcache/BagOStuff.php
+++ b/includes/libs/objectcache/BagOStuff.php
@@ -47,6 +47,7 @@
abstract class BagOStuff implements LoggerAwareInterface {
private $debugMode = false;
+ /** @var integer */
protected $lastError = self::ERR_NONE;
/**
@@ -109,8 +110,9 @@
/**
* Merge changes into the existing cache value (possibly creating a new
one).
- * The callback function returns the new value given the current value
(possibly false),
- * and takes the arguments: (this BagOStuff object, cache key, current
value).
+ * The callback function returns the new value given the current value
+ * (which will be false if not present), and takes the arguments:
+ * (this BagOStuff, cache key, current value).
*
* @param string $key
* @param callable $callback Callback method to be executed
@@ -334,7 +336,7 @@
* Decrease stored value of $key by $value while preserving its TTL
* @param string $key
* @param int $value
- * @return int
+ * @return int|bool New value or false on failure
*/
public function decr( $key, $value = 1 ) {
return $this->incr( $key, - $value );
--
To view, visit https://gerrit.wikimedia.org/r/205293
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0eea84bbbc4c742c07a35a2b157517ad9dd40bb8
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Aaron Schulz <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits