jenkins-bot has submitted this change and it was merged.
Change subject: Make the private checkbox to be a public checkbox
......................................................................
Make the private checkbox to be a public checkbox
Bug: T93391
Change-Id: I3fca2ed845ea28de8b11f590b1dd81058f5f9852
---
M i18n/en.json
M resources/Resources.php
M resources/ext.gather.collection.editor/CollectionEditOverlay.js
M resources/ext.gather.collection.editor/content.hogan
4 files changed, 5 insertions(+), 5 deletions(-)
Approvals:
Jhernandez: Looks good to me, approved
jenkins-bot: Verified
diff --git a/i18n/en.json b/i18n/en.json
index 45158f0..4f51dd1 100644
--- a/i18n/en.json
+++ b/i18n/en.json
@@ -37,7 +37,7 @@
"gather-edit-collection-heading": "Edit collection",
"gather-edit-collection-label-name": "Name",
"gather-edit-collection-label-description": "Description",
- "gather-edit-collection-label-privacy": "Private collection",
+ "gather-edit-collection-label-public": "Public collection",
"gather-edit-collection-save-label": "Done",
"gather-edit-collection-failed-error": "There was an issue with your
attempted change, please try something else.",
"gather-edit-collection-clear-label": "Clear",
diff --git a/resources/Resources.php b/resources/Resources.php
index 2ca7056..9172e0b 100644
--- a/resources/Resources.php
+++ b/resources/Resources.php
@@ -197,7 +197,7 @@
"gather-edit-collection-failed-error",
'gather-edit-collection-label-name',
'gather-edit-collection-label-description',
- 'gather-edit-collection-label-privacy',
+ 'gather-edit-collection-label-public',
'gather-edit-collection-save-label',
'gather-error-unknown-collection',
'gather-overlay-continue',
diff --git a/resources/ext.gather.collection.editor/CollectionEditOverlay.js
b/resources/ext.gather.collection.editor/CollectionEditOverlay.js
index 3323d2a..458a8cc 100644
--- a/resources/ext.gather.collection.editor/CollectionEditOverlay.js
+++ b/resources/ext.gather.collection.editor/CollectionEditOverlay.js
@@ -39,7 +39,7 @@
heading: mw.msg( 'gather-edit-collection-heading' ),
nameLabel: mw.msg( 'gather-edit-collection-label-name'
),
descriptionLabel: mw.msg(
'gather-edit-collection-label-description' ),
- privateLabel: mw.msg(
'gather-edit-collection-label-privacy' ),
+ publicLabel: mw.msg(
'gather-edit-collection-label-public' ),
headerButtonsListClassName: 'overlay-action',
continueMsg: mw.msg( 'gather-overlay-continue' ),
editMsg: mw.msg( 'gather-edit-button' ),
diff --git a/resources/ext.gather.collection.editor/content.hogan
b/resources/ext.gather.collection.editor/content.hogan
index cdb6e13..f4226f0 100644
--- a/resources/ext.gather.collection.editor/content.hogan
+++ b/resources/ext.gather.collection.editor/content.hogan
@@ -13,8 +13,8 @@
rows='2'>{{collection.description}}</textarea>
<div class="mw-ui-checkbox">
<input type="checkbox" id="collection-editor-privacy"
- {{^public}}checked{{/public}}
+ {{#collection.public}}checked{{/collection.public}}
disabled />
- <label for="collection-editor-privacy">{{privateLabel}}</label>
+ <label for="collection-editor-privacy">{{publicLabel}}</label>
</div>
</div>
--
To view, visit https://gerrit.wikimedia.org/r/204667
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3fca2ed845ea28de8b11f590b1dd81058f5f9852
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Gather
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson <[email protected]>
Gerrit-Reviewer: Jhernandez <[email protected]>
Gerrit-Reviewer: Siebrand <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
