Jonaskeutel has submitted this change and it was merged.
Change subject: add more check results (minor change in job test)
......................................................................
add more check results (minor change in job test)
Change-Id: Ia20d8d89d109b4b07d34e8c584b770bd852278f9
---
M tests/phpunit/CheckForViolationsJobTest.php
1 file changed, 4 insertions(+), 1 deletion(-)
Approvals:
Jonaskeutel: Verified; Looks good to me, approved
diff --git a/tests/phpunit/CheckForViolationsJobTest.php
b/tests/phpunit/CheckForViolationsJobTest.php
index 1fbcd71..e4fe56e 100644
--- a/tests/phpunit/CheckForViolationsJobTest.php
+++ b/tests/phpunit/CheckForViolationsJobTest.php
@@ -37,7 +37,10 @@
$constraintName = 'Single value';
$results = array();
$results[] = new CheckResult( $statement, $constraintName,
array(), CheckResult::STATUS_VIOLATION );
+ $results[] = new CheckResult( $statement, $constraintName,
array(), CheckResult::STATUS_VIOLATION );
$results[] = new CheckResult( $statement, $constraintName,
array(), CheckResult::STATUS_COMPLIANCE );
+ $results[] = new CheckResult( $statement, $constraintName,
array(), CheckResult::STATUS_COMPLIANCE );
+ $results[] = new CheckResult( $statement, $constraintName,
array(), CheckResult::STATUS_EXCEPTION );
$results[] = new CheckResult( $statement, $constraintName,
array(), CheckResult::STATUS_EXCEPTION );
$this->results = $results;
@@ -71,7 +74,7 @@
$count = $this->db->select(EVALUATION_TABLE, array(
'special_page_id' ), array ( 'special_page_id=1' ) )->numRows();
$result = $this->db->selectRow(EVALUATION_TABLE, array(
'result_string' ), array ( 'special_page_id=1' ) );
$this->assertEquals( 1, $count );
- $this->assertEquals( '{Compliances: {Single value: 1, },
{Violations: {Single value: 1, }, {Exceptions: {Single value: 1, }, ',
$result->result_string );
+ $this->assertEquals( '{Compliances: {Single value: 2, },
{Violations: {Single value: 2, }, {Exceptions: {Single value: 2, }, ',
$result->result_string );
}
public function testCheckForViolationJobDeferred() {
--
To view, visit https://gerrit.wikimedia.org/r/205602
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia20d8d89d109b4b07d34e8c584b770bd852278f9
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikidataQualityConstraints
Gerrit-Branch: master
Gerrit-Owner: Jonaskeutel <[email protected]>
Gerrit-Reviewer: Jonaskeutel <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
