jenkins-bot has submitted this change and it was merged.
Change subject: Filibuster: fix stringification errors
......................................................................
Filibuster: fix stringification errors
The DOM nodes referenced inside the DM nodes were causing JSON.stringify
to raise an error.
Change-Id: I64bdd4f58f3427ef2a7f99c10f5b4dadfda5b311
---
M src/ui/ve.ui.Surface.js
1 file changed, 3 insertions(+), 1 deletion(-)
Approvals:
Esanders: Looks good to me, approved
jenkins-bot: Verified
diff --git a/src/ui/ve.ui.Surface.js b/src/ui/ve.ui.Surface.js
index a9efe12..479157e 100644
--- a/src/ui/ve.ui.Surface.js
+++ b/src/ui/ve.ui.Surface.js
@@ -410,7 +410,9 @@
ve.ui.Surface.prototype.stopFilibuster
] )
.setObserver( 'dm doc', function () {
- return JSON.stringify(
surface.model.documentModel.data.data );
+ return JSON.stringify( ve.Filibuster.static.clonePlain(
+ surface.model.documentModel.data.data
+ ) );
} )
.setObserver( 'dm selection', function () {
var selection = surface.model.selection;
--
To view, visit https://gerrit.wikimedia.org/r/205604
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I64bdd4f58f3427ef2a7f99c10f5b4dadfda5b311
Gerrit-PatchSet: 1
Gerrit-Project: VisualEditor/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Divec <[email protected]>
Gerrit-Reviewer: Esanders <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
