[MediaWiki-commits] [Gerrit] ve.ce.MWEntityNode: Show whitespace characters, like in ve.c... - change (mediawiki...VisualEditor)

[Code Review]

Bartosz Dziewoński has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/205611

Change subject: ve.ce.MWEntityNode: Show whitespace characters, like in 
ve.ce.TextNode
......................................................................

ve.ce.MWEntityNode: Show whitespace characters, like in ve.ce.TextNode

So 	 used in page source will render the same as literal tab, etc.

(I have a hidden motivation vaguely related to T96666, but this is
probably a good idea anyway.)

Change-Id: I3d462dd4ece94a71645786fab8771788b991456a
---
M modules/ve-mw/ce/nodes/ve.ce.MWEntityNode.js
1 file changed, 8 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor 
refs/changes/11/205611/1

diff --git a/modules/ve-mw/ce/nodes/ve.ce.MWEntityNode.js 
b/modules/ve-mw/ce/nodes/ve.ce.MWEntityNode.js
index 46f7ac9..95c23b0 100644
--- a/modules/ve-mw/ce/nodes/ve.ce.MWEntityNode.js
+++ b/modules/ve-mw/ce/nodes/ve.ce.MWEntityNode.js
@@ -46,7 +46,14 @@
  * @method
  */
 ve.ce.MWEntityNode.prototype.onUpdate = function () {
-       this.$element.text( this.model.getAttribute( 'character' ) );
+       var
+               chr = this.model.getAttribute( 'character' ),
+               whitespaceHtmlChars = ve.ce.TextNode.whitespaceHtmlCharacters,
+               significantWhitespace = 
this.getModel().getParent().hasSignificantWhitespace();
+       if ( !significantWhitespace && Object.prototype.hasOwnProperty.call( 
whitespaceHtmlChars, chr ) ) {
+               chr = whitespaceHtmlChars[chr];
+       }
+       this.$element.text( chr );
 };
 
 /* Registration */

-- 
To view, visit https://gerrit.wikimedia.org/r/205611
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I3d462dd4ece94a71645786fab8771788b991456a
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Bartosz Dziewoński <matma....@gmail.com>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits