Jhernandez has uploaded a new change for review.
https://gerrit.wikimedia.org/r/205625
Change subject: Always point to collections menu item when creating a collection
......................................................................
Always point to collections menu item when creating a collection
Bug: T95976
Change-Id: Ibdf662a206f55856d906c38fabd62cf23f831d29
---
M resources/ext.gather.init/init.js
1 file changed, 11 insertions(+), 13 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Gather
refs/changes/25/205625/1
diff --git a/resources/ext.gather.init/init.js
b/resources/ext.gather.init/init.js
index 949a9de..2fdab91 100644
--- a/resources/ext.gather.init/init.js
+++ b/resources/ext.gather.init/init.js
@@ -97,19 +97,17 @@
if ( shouldShow ) {
showPointer( watchstar );
}
- watchstar.on( 'completed', function ( firstTimeUser ) {
- var p, tag;
- if ( firstTimeUser ) {
- // FIXME: Rename pointer overlay?
- p = new PageActionOverlay( {
- target: $( '#mw-mf-main-menu-button' ),
- summary: mw.msg( 'gather-menu-guider' ),
- cancelMsg: mw.msg(
'gather-add-to-collection-cancel' )
- } );
- p.show();
- // FIXME: Hacky.. Should use MainMenu but Bug:
T93257.
- tag = new Tag( { label: 'new' } ).appendTo(
'#mw-mf-page-left .collection-menu-item' );
- }
+ watchstar.on( 'completed', function () {
+ // FIXME: Rename pointer overlay?
+ new PageActionOverlay( {
+ target: $( '#mw-mf-main-menu-button' ),
+ summary: mw.msg( 'gather-menu-guider' ),
+ cancelMsg: mw.msg(
'gather-add-to-collection-cancel' )
+ } ).show();
+ // FIXME: Hacky.. Should use MainMenu but Bug: T93257.
+ new Tag( {
+ label: 'new'
+ } ).appendTo( '#mw-mf-page-left .collection-menu-item'
);
} );
}
--
To view, visit https://gerrit.wikimedia.org/r/205625
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibdf662a206f55856d906c38fabd62cf23f831d29
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Gather
Gerrit-Branch: master
Gerrit-Owner: Jhernandez <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
