Soeren.oldag has submitted this change and it was merged.
Change subject: SpecialCheckResultPage::execute() now takes Entity instead of
EntityDocument.
......................................................................
SpecialCheckResultPage::execute() now takes Entity instead of EntityDocument.
Change-Id: Ief1557742e1c9c55fdb67f0ec4cb40ccf503ec61
---
M specials/SpecialCheckResultPage.php
1 file changed, 6 insertions(+), 5 deletions(-)
Approvals:
Soeren.oldag: Checked; Looks good to me, approved
jenkins-bot: Verified
diff --git a/specials/SpecialCheckResultPage.php
b/specials/SpecialCheckResultPage.php
index 4a1c026..1b5a2f4 100644
--- a/specials/SpecialCheckResultPage.php
+++ b/specials/SpecialCheckResultPage.php
@@ -6,7 +6,7 @@
use Doctrine\Instantiator\Exception\InvalidArgumentException;
use Doctrine\Instantiator\Exception\UnexpectedValueException;
use Html;
-use Wikibase\DataModel\Entity\EntityDocument;
+use Wikibase\DataModel\Entity\Entity;
use Wikibase\DataModel\Entity\EntityId;
use Wikibase\DataModel\Entity\EntityIdParsingException;
use Traversable;
@@ -42,11 +42,11 @@
/**
* Executes the specific check for the given entity and returns results
*
- * @param EntityDocument $entity
+ * @param Entity $entity
*
* @return Traversable
*/
- protected abstract function executeCheck( EntityDocument $entity );
+ protected abstract function executeCheck( Entity $entity );
/**
* Returns text that is shown, if result list is empty
@@ -338,10 +338,11 @@
*
* @param DataValue|array $dataValues
* @param bool $linking
+ * @param string $separator
*
* @return string
*/
- protected function formatDataValues( $dataValues, $linking = true ) {
+ protected function formatDataValues( $dataValues, $linking = true,
$separator = ', ' ) {
if ( $dataValues instanceof DataValue ) {
$dataValues = array ( $dataValues );
} elseif ( !is_array( $dataValues ) ) {
@@ -364,6 +365,6 @@
}
}
- return implode( ', ', $formattedDataValues );
+ return implode( $separator, $formattedDataValues );
}
}
\ No newline at end of file
--
To view, visit https://gerrit.wikimedia.org/r/205844
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ief1557742e1c9c55fdb67f0ec4cb40ccf503ec61
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikidataQuality
Gerrit-Branch: master
Gerrit-Owner: Soeren.oldag <[email protected]>
Gerrit-Reviewer: Soeren.oldag <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
