jenkins-bot has submitted this change and it was merged.
Change subject: Performance: Use core-js/shim instead of es6-shim
......................................................................
Performance: Use core-js/shim instead of es6-shim
Get a ~12% speed-up by swapping out the es6 shim.
With es6-shim:
[info][enwiki/Barack_Obama] started parsing
[info][enwiki/Barack_Obama] completed parsing in 12549 ms
With core-js:
[info][enwiki/Barack_Obama] started parsing
[info][enwiki/Barack_Obama] completed parsing in 11099 ms
Both timings measured by the wt2html part of roundtrip-test.js,
which excludes startup time. Both on my laptop, wired connection in
the office. Results were stable across several runs.
Requires chai v2.1.1 for the mocha tests to pass
Bug: T89775
Change-Id: Iaa5cb8ce904a39836f5ce3e54683b20f329ec35c
---
M lib/core-upgrade.js
M package.json
2 files changed, 3 insertions(+), 3 deletions(-)
Approvals:
Subramanya Sastry: Looks good to me, approved
jenkins-bot: Verified
diff --git a/lib/core-upgrade.js b/lib/core-upgrade.js
index 5238230..f010455 100644
--- a/lib/core-upgrade.js
+++ b/lib/core-upgrade.js
@@ -1,5 +1,5 @@
"use strict";
-require('es6-shim');
+require('core-js/shim');
require('prfun');
if (!Array.prototype.last) {
Object.defineProperty(Array.prototype, 'last', {
diff --git a/package.json b/package.json
index 24ed622..46d7e42 100644
--- a/package.json
+++ b/package.json
@@ -8,10 +8,10 @@
"async": "~0.9.0",
"bunyan": "~1.0.0",
"compression": "~1.4.0",
+ "core-js": "^0.8.1",
"diff": "~1.0.7",
"domino": "~1.0.18",
"entities": "~1.1.1",
- "es6-shim": "~0.16.0",
"express": "~2.5.11",
"gelf-stream": "~0.2.4",
"handlebars": "~1.3.0",
@@ -25,7 +25,7 @@
"yargs": "~1.3.1"
},
"devDependencies": {
- "chai": "~1.9.1",
+ "chai": "~2.1.1",
"colors": "~0.6.2",
"coveralls": "2.11.2",
"istanbul": "0.3.5",
--
To view, visit https://gerrit.wikimedia.org/r/191220
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iaa5cb8ce904a39836f5ce3e54683b20f329ec35c
Gerrit-PatchSet: 14
Gerrit-Project: mediawiki/services/parsoid
Gerrit-Branch: master
Gerrit-Owner: GWicke <[email protected]>
Gerrit-Reviewer: Arlolra <[email protected]>
Gerrit-Reviewer: Cscott <[email protected]>
Gerrit-Reviewer: GWicke <[email protected]>
Gerrit-Reviewer: Marcoil <[email protected]>
Gerrit-Reviewer: Ori.livneh <[email protected]>
Gerrit-Reviewer: Subramanya Sastry <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
