jenkins-bot has submitted this change and it was merged.
Change subject: Rewrite ChunkAccess<Change> type hints
......................................................................
Rewrite ChunkAccess<Change> type hints
Change-Id: I95e77d9e9bed37e9c4a6a9868cc6d5edd2b42c62
---
M client/includes/store/ClientStore.php
M repo/includes/ChangeDispatcher.php
M repo/tests/phpunit/includes/ChangeDispatcherTest.php
3 files changed, 7 insertions(+), 6 deletions(-)
Approvals:
Daniel Kinzler: Looks good to me, approved
jenkins-bot: Verified
diff --git a/client/includes/store/ClientStore.php
b/client/includes/store/ClientStore.php
index b7cdbfc..66b381a 100644
--- a/client/includes/store/ClientStore.php
+++ b/client/includes/store/ClientStore.php
@@ -2,7 +2,7 @@
namespace Wikibase;
-use Wikibase\Store\EntityIdLookup;
+use MWException;
use Wikibase\Client\Usage\SubscriptionManager;
use Wikibase\Client\Usage\UsageLookup;
use Wikibase\Client\Usage\UsageTracker;
@@ -10,6 +10,7 @@
use Wikibase\Lib\Store\EntityPrefetcher;
use Wikibase\Lib\Store\EntityRevisionLookup;
use Wikibase\Lib\Store\SiteLinkLookup;
+use Wikibase\Store\EntityIdLookup;
/**
* Client store interface.
@@ -88,9 +89,8 @@
/**
* @since 0.4
*
+ * @throws MWException if no changes table can be supplied.
* @return ChangesTable
- *
- * @throws \MWException if no changes table can be supplied.
*/
public function newChangesTable();
diff --git a/repo/includes/ChangeDispatcher.php
b/repo/includes/ChangeDispatcher.php
index 4113164..3b82c44 100644
--- a/repo/includes/ChangeDispatcher.php
+++ b/repo/includes/ChangeDispatcher.php
@@ -62,7 +62,7 @@
private $messageReporter;
/**
- * @var ChunkAccess<Change> : access to the changes
tablchangesCachechangesCachee
+ * @var ChunkAccess Access to the changes table.
*/
private $chunkedChangesAccess;
@@ -74,7 +74,8 @@
/**
* @param ChangeDispatchCoordinator $coordinator
* @param ChangeNotificationSender $notificationSender
- * @param ChunkAccess<Change> $chunkedChangesAccess
+ * @param ChunkAccess $chunkedChangesAccess Access to the changes
table. Should only return
+ * Change objects from loadChunk.
* @param SubscriptionLookup $subscriptionLookup
*/
public function __construct(
diff --git a/repo/tests/phpunit/includes/ChangeDispatcherTest.php
b/repo/tests/phpunit/includes/ChangeDispatcherTest.php
index 5c8fb57..33583c6 100644
--- a/repo/tests/phpunit/includes/ChangeDispatcherTest.php
+++ b/repo/tests/phpunit/includes/ChangeDispatcherTest.php
@@ -81,7 +81,7 @@
}
/**
- * @return ChunkAccess<Change>
+ * @return ChunkAccess Guaranteed to only return Change objects from
loadChunk.
*/
private function getChunkedChangesAccess() {
$chunkedAccess = $this->getMock( 'Wikibase\ChunkAccess' );
--
To view, visit https://gerrit.wikimedia.org/r/204231
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I95e77d9e9bed37e9c4a6a9868cc6d5edd2b42c62
Gerrit-PatchSet: 4
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Thiemo Mättig (WMDE) <[email protected]>
Gerrit-Reviewer: Daniel Kinzler <[email protected]>
Gerrit-Reviewer: Jeroen De Dauw <[email protected]>
Gerrit-Reviewer: Thiemo Mättig (WMDE) <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
